Skip to content

[test](eager)aggfunc slots and group by key slots intersect #64416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
englefly wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −6
Draft

[test](eager)aggfunc slots and group by key slots intersect #64416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...main/java/org/apache/doris/nereids/rules/rewrite/eageraggregation/PushDownAggContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ public PushDownAggContext(List<AggregateFunction> aggFunctions,
* @return true, if groupKeys is not empty and no group by key is in aggFunctionsInputSlots
*/
public boolean isValid() {
return !groupKeys.isEmpty()
&& !groupKeys.stream().anyMatch(s -> aggFunctionsInputSlots.contains(s));
return !groupKeys.isEmpty();
}

public PushDownAggContext passThroughBigJoin() {
Expand Down
8 changes: 4 additions & 4 deletions ...ain/java/org/apache/doris/nereids/rules/rewrite/eageraggregation/PushDownAggregation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,10 @@ public Plan visitLogicalAggregate(LogicalAggregate<? extends Plan> agg, JobConte
If body = (If) (aggFunction).child(0);
Set<Slot> valueSlots = Sets.newHashSet(body.getTrueValue().getInputSlots());
valueSlots.addAll(body.getFalseValue().getInputSlots());
if (body.getCondition().getInputSlots().stream().anyMatch(s -> valueSlots.contains(s))) {
// do not push down sum(if a then a else b)
return agg;
}
// if (body.getCondition().getInputSlots().stream().anyMatch(s -> valueSlots.contains(s))) {
// // do not push down sum(if a then a else b)
// return agg;
// }
AggregateFunction aggTrue = (AggregateFunction) aggFunction.withChildren(body.getTrueValue());
aggFunctions.add(aggTrue);
funcs.add(aggTrue);
Expand Down
Loading