Skip to content

[fix](cloud) Skip empty rowsets before accessor lookup in batch delete_rowset_data #60919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liaoxin01 merged 1 commit into from
Mar 10, 2026
Merged

[fix](cloud) Skip empty rowsets before accessor lookup in batch delete_rowset_data #60919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions cloud/src/recycler/recycler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3365,6 +3365,18 @@ int InstanceRecycler::delete_rowset_data(
}
}

int64_t num_segments = rs.num_segments();
// Check num_segments before accessor lookup, because empty rowsets
// (e.g. base compaction output of empty rowsets) may have no resource_id
// set. Skipping them early avoids a spurious "no such resource id" error
// that marks the entire batch as failed and prevents txn_remove from
// cleaning up recycle KV keys.
if (num_segments <= 0) {
metrics_context.total_recycled_num++;
metrics_context.total_recycled_data_size += rs.total_disk_size();
continue;
}
Comment thread
liaoxin01 marked this conversation as resolved.

auto it = accessor_map_.find(rs.resource_id());
// possible if the accessor is not initilized correctly
Comment thread
liaoxin01 marked this conversation as resolved.
if (it == accessor_map_.end()) [[unlikely]] {
Expand All @@ -3387,12 +3399,6 @@ int InstanceRecycler::delete_rowset_data(
ret = -1;
continue;
}
int64_t num_segments = rs.num_segments();
if (num_segments <= 0) {
metrics_context.total_recycled_num++;
metrics_context.total_recycled_data_size += rs.total_disk_size();
continue;
}

// Process delete bitmap
file_paths.push_back(delete_bitmap_path(tablet_id, rowset_id));
Expand Down
Loading