[refine](code) remove erase_useless_column function by Mryange · Pull Request #60898 · apache/doris

Mryange · 2026-02-28T02:34:21Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2026-02-28T02:34:26Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Mryange · 2026-02-28T02:34:29Z

run buildall

yiguolei · 2026-02-28T02:38:33Z

be/src/pipeline/exec/analytic_sink_operator.cpp

 }

-Status AnalyticSinkOperatorX::_insert_range_column(vectorized::Block* block,
+Status AnalyticSinkOperatorX::_insert_range_column(const vectorized::Block* block,


这里如果是const，应该改成const &

doris-robot · 2026-02-28T03:31:40Z

TPC-H: Total hot run time: 28836 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 74cc7c6e220bfcc8d7ee24069ced759452aa79cc, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17619	4495	4317	4317
q2	q3	10646	837	519	519
q4	4681	355	256	256
q5	7552	1213	1038	1038
q6	179	176	149	149
q7	796	842	677	677
q8	9300	1513	1413	1413
q9	4768	4731	4690	4690
q10	6834	1881	1628	1628
q11	459	278	244	244
q12	744	567	473	473
q13	17764	4244	3431	3431
q14	229	226	211	211
q15	977	801	782	782
q16	769	728	660	660
q17	725	906	422	422
q18	6059	5495	5244	5244
q19	1222	982	620	620
q20	520	506	396	396
q21	4559	1839	1422	1422
q22	338	288	244	244
Total cold run time: 96740 ms
Total hot run time: 28836 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4420	4373	4388	4373
q2	q3	1789	2170	1706	1706
q4	844	1163	757	757
q5	4035	4348	4332	4332
q6	180	173	144	144
q7	1742	1587	1489	1489
q8	2632	2661	2545	2545
q9	7625	7576	7425	7425
q10	2699	2807	2436	2436
q11	508	438	413	413
q12	511	593	489	489
q13	4039	4495	3652	3652
q14	292	361	279	279
q15	852	834	830	830
q16	729	776	740	740
q17	1196	1599	1362	1362
q18	7091	6814	6544	6544
q19	939	932	917	917
q20	2076	2164	1999	1999
q21	3942	3551	3446	3446
q22	461	446	382	382
Total cold run time: 48602 ms
Total hot run time: 46260 ms

doris-robot · 2026-02-28T03:43:04Z

TPC-DS: Total hot run time: 184370 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 74cc7c6e220bfcc8d7ee24069ced759452aa79cc, data reload: false

query5	5155	649	540	540
query6	326	230	206	206
query7	4212	466	266	266
query8	340	243	238	238
query9	8704	2741	2730	2730
query10	580	372	323	323
query11	16955	17429	17294	17294
query12	234	154	135	135
query13	1364	478	366	366
query14	6925	3376	3078	3078
query14_1	2933	3118	2902	2902
query15	230	235	196	196
query16	1034	476	475	475
query17	1290	776	660	660
query18	2846	458	417	417
query19	221	220	201	201
query20	150	145	136	136
query21	272	138	121	121
query22	5442	5083	4922	4922
query23	17255	16900	16655	16655
query23_1	16748	16709	16652	16652
query24	7110	1646	1227	1227
query24_1	1234	1255	1249	1249
query25	584	480	424	424
query26	1241	265	154	154
query27	2745	473	291	291
query28	4453	1858	1863	1858
query29	782	563	480	480
query30	315	245	207	207
query31	870	715	639	639
query32	82	69	72	69
query33	515	335	288	288
query34	906	911	555	555
query35	645	670	594	594
query36	1068	1139	939	939
query37	152	100	82	82
query38	3033	2895	2880	2880
query39	901	853	843	843
query39_1	835	810	813	810
query40	226	157	133	133
query41	66	60	62	60
query42	107	106	103	103
query43	379	386	350	350
query44	
query45	194	188	183	183
query46	881	963	608	608
query47	2137	2137	2024	2024
query48	310	322	225	225
query49	622	457	372	372
query50	691	273	214	214
query51	4059	4113	4087	4087
query52	109	107	96	96
query53	304	334	290	290
query54	295	276	265	265
query55	94	82	84	82
query56	312	359	319	319
query57	1369	1319	1290	1290
query58	282	278	273	273
query59	2600	2660	2494	2494
query60	330	339	323	323
query61	149	143	153	143
query62	626	587	537	537
query63	309	277	271	271
query64	4848	1274	1002	1002
query65	
query66	1374	508	363	363
query67	16381	16372	16435	16372
query68	
query69	399	312	278	278
query70	999	996	939	939
query71	347	304	304	304
query72	2751	2666	2552	2552
query73	554	553	334	334
query74	9980	9893	9789	9789
query75	2849	2751	2453	2453
query76	2313	1027	676	676
query77	373	400	290	290
query78	11210	11412	10718	10718
query79	3018	828	615	615
query80	1778	653	544	544
query81	587	280	246	246
query82	970	150	113	113
query83	332	268	243	243
query84	255	112	92	92
query85	891	485	433	433
query86	431	313	326	313
query87	3096	3129	2998	2998
query88	3568	2671	2655	2655
query89	422	374	350	350
query90	1950	173	171	171
query91	167	155	132	132
query92	73	74	69	69
query93	1258	836	500	500
query94	652	329	280	280
query95	597	336	327	327
query96	630	511	226	226
query97	2479	2485	2435	2435
query98	236	221	219	219
query99	1004	973	914	914
Total cold run time: 257328 ms
Total hot run time: 184370 ms

hello-stephen · 2026-02-28T04:20:17Z

BE UT Coverage Report

Increment line coverage 54.55% (6/11) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.55% (19586/37274)
Line Coverage	36.20% (182999/505472)
Region Coverage	32.52% (142030/436766)
Branch Coverage	33.48% (61571/183902)

hello-stephen · 2026-02-28T05:54:42Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (11/11) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.31% (26762/36507)
Line Coverage	56.61% (285326/503978)
Region Coverage	54.06% (238390/440942)
Branch Coverage	55.69% (102748/184494)

upd

74cc7c6

yiguolei reviewed Feb 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[refine](code) remove erase_useless_column function#60898

[refine](code) remove erase_useless_column function#60898
Mryange wants to merge 1 commit intoapache:masterfrom
Mryange:remove-erase_useless_column-api

Mryange commented Feb 28, 2026

Uh oh!

hello-stephen commented Feb 28, 2026

Uh oh!

Mryange commented Feb 28, 2026

Uh oh!

yiguolei Feb 28, 2026

Uh oh!

doris-robot commented Feb 28, 2026

Uh oh!

doris-robot commented Feb 28, 2026

Uh oh!

hello-stephen commented Feb 28, 2026

Uh oh!

hello-stephen commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Mryange commented Feb 28, 2026

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Feb 28, 2026

Uh oh!

Mryange commented Feb 28, 2026

Uh oh!

yiguolei Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Feb 28, 2026

Uh oh!

doris-robot commented Feb 28, 2026

Uh oh!

hello-stephen commented Feb 28, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Feb 28, 2026

BE Regression && UT Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants