[fix](broker load)fix wildcard import failure caused by 0-byte metadata files#59486
Open
qidaye wants to merge 1 commit intoapache:masterfrom
Open
[fix](broker load)fix wildcard import failure caused by 0-byte metadata files#59486qidaye wants to merge 1 commit intoapache:masterfrom
qidaye wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
qidaye
force-pushed
the
fix_broker_load_wildcard_import
branch
from
d7134e0 to
98b984c
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34667 ms |
TPC-DS: Total hot run time: 173437 ms |
ClickBench: Total hot run time: 26.84 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
qidaye
force-pushed
the
fix_broker_load_wildcard_import
branch
from
98b984c to
41ecdde
Compare
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 36219 ms |
TPC-DS: Total hot run time: 174263 ms |
ClickBench: Total hot run time: 26.94 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
qidaye
requested review from
morningman and
starocean999
and removed request for
morningman
cambyzju
reviewed
Dec 31, 2025
| List<TBrokerFileStatus> filteredFileStatuses = Lists.newArrayList(); | ||
| for (TBrokerFileStatus fstatus : fileStatuses) { | ||
| if (fstatus.getSize() == 0 && isBinaryFileFormat) { | ||
| boolean isSuccessFile = fstatus.path.endsWith("/_SUCCESS") |
Contributor
There was a problem hiding this comment.
是不是可以类似这个pr：（#59398）把下划线和点开头的文件都过滤一下？如果担心影响比较大，可以在broker load的option里加一个开关。
Contributor
Author
There was a problem hiding this comment.
支持一个file Group中指定不同的文件类型后，这里其实不过滤也没有问题了。目前是为了保险起见增加了这个_SUCCESS文件的特殊过滤。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When performing a Broker Load with wildcards (e.g.,
/*), if the directory contains0-byte metadata files like
_SUCCESS, the FE would incorrectly use the format/compressionof these metadata files (usually PLAIN) to overwrite the shared parameters for the
entire file group. This caused the BE to read compressed data files (like LZO) as
plain text, leading to import failures.
This PR fixes the issue by:
_SUCCESSfiles inBrokerLoadPendingTaskto avoid processingthem as data.
format_typeandcompress_typein eachTFileRangeDescinstead ofthe shared
TFileScanRangeParamsin FE (both legacy and Nereids paths).format_typein BE'sCsvReaderto ensure the correctreader is initialized for each file.
_SUCCESSfilteringRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)