Repository navigation
refactor(xor): remove persisted item counts - #795
Merged
Merged
Conversation
Member
Author
|
The Rust counterpart uses the same header and serialization version 1. Its serialization tests consume scalar and UTF-8/raw-byte fixtures generated from this PR's |
Member
|
We have just found a critical fix. So this RC-1. is cancelled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XOR membership queries need the construction seed, segment layout, and fingerprints, but not the number of input hashes. Remove the finished filter's count and
getNumItems(),isEmpty(), andgetBitsPerItem(). The builder still tracks its updates.The serialized header occupies 24 bytes: flags at byte 3, fingerprint width at byte 4, seed at byte 8, and segment length at byte 16. Remaining bytes are reserved. Writers emit zero flags; readers reject unsupported flags. The layout has three fingerprint segments and no persisted item count.
Release compatibility needs resolution before merging. Java 9.1.0-RC1 contains the count-bearing version-1 format and the three public methods. This PR currently retains serialization version 1 and removes those methods. If that release ships first, this PR needs a distinct format version with a legacy reader, and an agreed API migration. It must not be released as a compatible minor update in its current form.
Validation:
mvn -B clean verifypasses all 2,335 tests. Coverage includes heapify/wrap round trips, reference images, unsupported flags, truncated images, fingerprint widths, hash count, and capacity invariants. The preamble error message now refers to longs rather than bytes.