Repository navigation
perf: tdigest grows its buffers as they fill - #561
rustyconover wants to merge 1 commit into
Conversation
The constructor reserved room for 2k + fudge centroids and four times as many buffered values (about 10 KB for k = 100 with doubles), also when deserializing. Code that holds many small t-digests paid for all of it. Grow the buffer geometrically up to its limit on update, and the centroids before a compress or merge needs them. Results are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3dee23d to
15024ac
Compare
|
Thanks, Rusty. Same situation as #558: we'd like one allocation convention across the sketches and languages before merging either. The dev@ proposal, a lazy consensus ending Nov 7, 01:00 UTC, is here: https://lists.apache.org/thread/rv730qo61qqkd99dcy4wnglf3hz1s0fz I'm marking this PR as a draft until that resolves. If it passes, this PR fits it well. The geometric growth up to the existing limits is the behavior the proposal describes, and we'd only add a |
|
@leerho thanks for outlining the remaining work. The proposal's deadline has now passed, so I've followed up on #558 to confirm the outcome, when both PRs can leave draft, and who will handle All 21 checks on this PR's current commit ( |
tdigest's constructor reserves room for2k + fudgecentroids andBUFFER_MULTIPLIERtimes as many buffered values. Fork = 100withdoublethat's about 10 KB per digest before anything is added, and it happens again on everydeserialize().This is the same kind of change as #558 for
kll_sketch. Instead of reserving everything up front:update()grows the buffer geometrically, starting at 8 values and doubling up to its existing limit.compress()andmerge()grow the centroids before they need them, also up to the existing limit.Results and the serialized format are unchanged.
Test
Added
tdigest custom allocator: buffers grow as they filltotdigest_custom_allocator_test.cpp, usingtest_allocator:REQUIRE( test_allocator_total_bytes == 0 ).std::allocatorwithout the change.All 17 test suites pass under CTest (GCC 14, aarch64).
We found this in the DuckDB DataSketches extension. For GROUP BY queries with many groups, DuckDB creates a state for each input row and merges them later, so the up-front reservation multiplied by millions of states. DuckDB made the same change to its own t-digest.
🤖 Generated with Claude Code