Repository navigation
fix: respect batch size in bounded window aggregation - #26970
Closed
xiaobai0529 wants to merge 1 commit into
Closed
xiaobai0529 wants to merge 1 commit into
xiaobai0529 wants to merge 1 commit into
Conversation
Generated-by: Codex (GPT-6)
Member
|
Superseded by #26974 Thank you for the contribution, and sorry we haven't reviewed your work. One challenge we're facing is that we can't easily tell from a PR alone whether it's largely AI-generated or carefully engineered. We still welcome new contributors! I suggest to start by reviewing PRs or helping with smaller maintenance tasks in actively developed areas to build trust with existing maintainers, then coordinate with them before working on features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #26959
Rationale for this change
Window queries that need lookahead can emit batches larger than the configured batch size when buffered rows become ready together. For example, with batch size 2, a
ROWS ... 6 FOLLOWINGquery can emit batches of 1, 2, and 7 rows.What changes are included in this PR?
Split computed output into zero-copy slices bounded by the configured batch size. Drain pending slices before reading more input, including after the input ends, preserving row order and window state.
What is the testing strategy for this PR?
[1, 2, 7].cargo fmt --all, andcargo clippy --all-targets --all-features -- -D warnings.AGENTS.mdsuccessfully. The isolated Linux test checkout used the pinned test-data submodules and LF line endings for the TPC-H q15 SQL file.Are there any user-facing changes?
Output from
BoundedWindowAggExecrespects the configured batch size. Query rows and their order are preserved; batch boundaries may change.AI assistance
Codex (GPT-6) assisted with implementation, testing, and this description. The contributor reviewed the change and confirmed understanding of the design.