chore: Update Rust toolchain to 1.98.1 - #25295
Merged
Merged
Conversation
Bump the pinned toolchain, and the depcheck sub-workspace toolchain, from 1.97.0 to 1.98.1, and resolve everything clippy 1.98 newly reports so that `cargo clippy -- -D warnings` stays clean: - chunks_exact_to_as_chunks: use `as_chunks` / `as_chunks_mut`. In the null-mask loops in `accumulate.rs` the remainder now comes from the returned tuple, and callers that walk fixed-size pairs destructure them directly instead of indexing. - with_capacity_zero, useless_format, needless_late_init: apply the suggested simplifications. - unused_imports: drop the glob imports in the `hash_utils` test module that duplicate what `use super::*` already provides. - result_large_err: clippy 1.98 reports this for `async fn`s returning `object_store::Result`, whose error type exceeds the workspace threshold. Mark those sites with `#[expect]`, since the error type is fixed by the object_store API. - unused_async_trait_impl: add it to the existing `#[expect(unused_async)]` on the intentionally async methods in the remote_catalog example. Also remove the `from_iter_instead_of_collect` entry from the workspace clippy allow list, since clippy 1.98 removed that lint.
github-actions
Bot
added
documentation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #25295 +/- ##
==========================================
- Coverage 81.91% 81.91% -0.01%
==========================================
Files 1134 1134
Lines 425637 425636 -1
Branches 425637 425636 -1
==========================================
- Hits 348654 348646 -8
- Misses 56302 56309 +7
Partials 20681 20681 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
martin-g
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Periodic update to latest stable Rust toolchain.
What changes are included in this PR?
depchecksub-workspace toolchainfrom_iter_instead_of_collectfrom workspace clippy allow list (lint was removed in 1.98)What is the testing strategy for this PR?
Compiles cleanly, all clippy / lint checks pass with no new warnings.
Are there any user-facing changes?
No.