fix: treat missing parquet null counts as zero only for legacy writer… - #25290
Open
Cherylgabba wants to merge 2 commits into
Open
fix: treat missing parquet null counts as zero only for legacy writer…#25290Cherylgabba wants to merge 2 commits into
Cherylgabba wants to merge 2 commits into
Conversation
Cherylgabba
force-pushed
the
fix/missing-null-counts-zero-for-old-parquet-rs
branch
from
September 14, 2026 11:45
95eca72 to
c1e75d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #25253
Rationale for this change
parquet-rs < 53.1.0 (e.g. the version linked by DataFusion < 42.1.0) did not record a null_count in row-group statistics when it was zero. Treating a missing null_count as exactly zero is therefore a safe optimization for those files — but it is wrong for every other writer that genuinely omits null counts. Assuming zero for those files lets IS NULL / COUNT row-group pruning, file statistics, limit pruning and sort pushdown return incorrect results.
What changes are included in this PR?
What is the testing strategy for this PR?
Are there any user-facing changes?
Yes, an upgrade-guide note was added to docs/source/library-user-guide/upgrading/56.0.0.md. Users of files written by old parquet-rs/DataFusion writers gain back exact statistics, row-group pruning and sort pushdown; files from other writers that omit null counts are now handled conservatively instead of returning wrong results.