DRAFT Test aggmetrics3 - #25237

Draft

kosiew wants to merge 36 commits into

apache:mainfrom

kosiew:test-aggmetrics3

Commits on Sep 9, 2026

feat: add data‑free SQL harness for array_agg_distinct benchmark
kosiew
committed
68c6fd8
chore: adjust benchmark scope from 1M to 100K groups
kosiew
committed
713afe2

Commits on Sep 11, 2026

bench: scale array_agg distinct groups
kosiew
committed
e015a1a

Commits on Sep 14, 2026

feat: add benchmarks for GroupsAccumulatorAdapter
kosiew
committed
51e8497
fix: adjust comment formatting in groups_accumulator_adapter benchmark
kosiew
committed
6b8155e
empty commit
kosiew
committed
ea83270
feat: add optional AggregateMetric API with lazy internal timers and comprehensive tests
kosiew
committed
43ba7b4
feat(metrics): safe refactors to avoid redundant allocations and improve performance
kosiew
committed
add4dbd
fix: assert both internal_distinct timers are >0 in test
kosiew
committed
9bf5850
docs: update metrics.md with identity/cardinality, accumulator timer, partition display, and empty input behavior
kosiew
committed
8500d50
fix(DistinctArrayAggAccumulator): correct `size()` calculation
kosiew
committed
1075a78
feat(aggregates): add 2‑partition execution test and fix array_agg distinct identities and timer handling
kosiew
committed
61ed2b9
feat(metrics): add lock‑free OnceLock fast path for AggregateSubMetrics
kosiew
committed
9669a50
fix: restore Time::add min‑1ns behavior and remove exact‑duration API
kosiew
committed
edbafbb
fix(time): corrected split to preserve exact duration adds and avoid per‑batch 1 ns inflation
kosiew
committed
78bec05
feat(metrics): require RefUnwindSafe for AggregateMetric and add compile‑time test for DistinctArrayAggAccumulator
kosiew
committed
1978756
test: add legacy grouped `array_agg(DISTINCT)` metric test
kosiew
committed
363efba
fix(array_agg): skip internal DISTINCT timing for small batches and improve per-group metrics
kosiew
committed
466467f
feat(datafusion): add grouped update metric and update_batch_grouped for accumulators
kosiew
committed
031f7a1
fix(groups_accumulator): improve Instant usage and fix unnecessary Option clone
kosiew
committed
d48a874
refactor: simplify distinct_metric cloning in DistinctArrayAggAccumulator
kosiew
committed
f58d726
feat(metrics): add array_agg(DISTINCT) merge, convert_to_state, and metric-count regressions
kosiew
committed
93918f6
feat: cache aggregate metric handles for grouped accumulators
kosiew
committed
d7749ba
feat(groups-accumulator-adapter): move slice/filter prep outside timing, bound prep chunks, time only accumulator calls, and emit one metric update per logical batch
kosiew
committed
9d6e9db
feat: convert_to_state uses bounded 64‑row prep chunks with timer‑wrapped batch updates and adds regression test
kosiew
committed
f3ed57b
refactor: simplify metric lookup and consolidate implementation blocks, import AggregateMetrics
kosiew
committed
fe23635
empty commit2-before merge main
kosiew
committed
4faf1b5
fix(metrics): create execution-owned aggregate_sub_metrics helper and propagate to accumulators
kosiew
committed
eafaa43
docs: clarify metrics documentation about internal submetrics
kosiew
committed
9716814
perf(aggregate): move size accounting out of timer and improve error handling in GroupsAccumulatorAdapter
kosiew
committed
f7969dd
test: add regression test for groups_accumulator
kosiew
committed
38d72dc
fix: clear successful groups before propagating later-group error and add retry regression
kosiew
committed
f48ce70
fix: update array_agg_distinct benchmark group size from 100K to 1000K
kosiew
committed
af82e47
feat: implement fast path for uninstrumented aggregates
kosiew
committed
f6fba7d
merge with main
kosiew
committed
d30fe36

Commits on Sep 15, 2026

refactor(datafusion/functions-aggregate-common/src/aggregate/groups_accumulator): improve groups accumulator memory accounting
kosiew
committed
f3e7063