Skip to content

feat: replace_children#23903

Draft
JSOD11 wants to merge 3 commits into
apache:mainfrom
JSOD11:jsod/replace-children-07-25-26
Draft

feat: replace_children#23903
JSOD11 wants to merge 3 commits into
apache:mainfrom
JSOD11:jsod/replace-children-07-25-26

Conversation

@JSOD11

@JSOD11 JSOD11 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Jul 26, 2026
@codecov-commenter

codecov-commenter commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.08108% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.66%. Comparing base (88365dd) to head (1fdc7ab).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...sion/physical-optimizer/src/hash_join_buffering.rs 41.66% 7 Missing ⚠️
datafusion/physical-plan/src/unnest.rs 86.95% 3 Missing ⚠️
...n/physical-plan/src/sorts/sort_preserving_merge.rs 90.00% 2 Missing ⚠️
...sion/physical-optimizer/src/output_requirements.rs 0.00% 0 Missing and 1 partial ⚠️
datafusion/physical-plan/src/execution_plan.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23903      +/-   ##
==========================================
+ Coverage   80.65%   80.66%   +0.01%     
==========================================
  Files        1093     1094       +1     
  Lines      371619   371806     +187     
  Branches   371619   371806     +187     
==========================================
+ Hits       299730   299922     +192     
+ Misses      53993    53980      -13     
- Partials    17896    17904       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the optimizer Optimizer rules label Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(physical-plan): simplify ExecutionPlan children-replacement API

2 participants