Add DataSource/FileSource proto hooks and FileScanConfig serde#23683
Open
kumarUjjawal wants to merge 2 commits into
Open
Add DataSource/FileSource proto hooks and FileScanConfig serde#23683kumarUjjawal wants to merge 2 commits into
kumarUjjawal wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23683 +/- ##
==========================================
+ Coverage 80.67% 80.69% +0.01%
==========================================
Files 1087 1088 +1
Lines 367541 368315 +774
Branches 367541 368315 +774
==========================================
+ Hits 296529 297200 +671
- Misses 53355 53400 +45
- Partials 17657 17715 +58 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
File scan serialization currently depends on central type downcasts in
datafusion-proto.This PR adds the foundation needed to move each data source to its own protobuf hooks while preserving the existing wire format and fallback behavior.
It unblocks the concrete source migrations tracked by #23516, #23517, and #23518.
What changes are included in this PR?
try_to_protohooks toDataSourceandFileSource.DataSourceExecthroughFileScanConfigto its concreteFileSource.FileScanConfigprotobuf encoding and decoding in the datasource crate.Ok(None).Are these changes tested?
Yes
Are there any user-facing changes?
This adds non-breaking, feature-gated public serialization hooks for data source and file source implementations.