chore: Enable unused_async lint#23679
Open
neilconway wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
If it is preferred, I can revert the changes to the public APIs and add |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23679 +/- ##
==========================================
- Coverage 80.67% 80.67% -0.01%
==========================================
Files 1086 1087 +1
Lines 366800 367527 +727
Branches 366800 367527 +727
==========================================
+ Hits 295912 296491 +579
- Misses 53260 53374 +114
- Partials 17628 17662 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
There are a reasonable number of places where we have functions marked as
asyncthat don't need to be so. Fix this by enabling theunused_asynclint, and fixing up the resulting breakage. There are a handful of spots that need anexpect(clippy::unused_async)-- mostly mocks ofasyncmethods and example code.What changes are included in this PR?
unused_asynclintasyncannotations in a bunch of placesexpect(clippy::unused_async)where necessaryAre these changes tested?
Yes, covered by existing tests (no behavioral change expected).
Are there any user-facing changes?
Yes: this PR updates a few public APIs:
datafusion_cli::command::OutputFormat::executedatafusion::test_util::parquet::TestParquetFile::create_scandatafusion_datasource_csv::file_format::CsvFormat::read_to_delimited_chunks_from_streamdatafusion_substrait::serializer::deserialize_bytesMigration is mostly straightforward (e.g., removing
awaitfrom calling code).