feat: removed all instances of deprecated virtualtable values field#23672
Open
eliot1480 wants to merge 1 commit into
Open
feat: removed all instances of deprecated virtualtable values field#23672eliot1480 wants to merge 1 commit into
eliot1480 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23672 +/- ##
=======================================
Coverage 80.66% 80.67%
=======================================
Files 1086 1086
Lines 366673 366740 +67
Branches 366673 366740 +67
=======================================
+ Hits 295786 295853 +67
+ Misses 53263 53261 -2
- Partials 17624 17626 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Since the VirtualTables.values field has been deprecated and is soon to be removed in the next substrait update, we should make sure to delete all instances of it to prevent the presence of dead code.
What changes are included in this PR?
Producer now emits VirtualTable.expressions for Values and EmptyRelation, and the consumer now only reads VirtualTable.expressions. Converted 17 direct virtualTable.values entries across 10 JSON test plans to virtualTable.expressions.
Are these changes tested?
Yes they are. Tests ran:
jq validation for JSON fixtures
Are there any user-facing changes?
No.