fix(datasource): avoid over-conservative transformation of num_rows statistics in file scan config#23670
Open
tschwarzinger wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23670 +/- ##
==========================================
- Coverage 80.67% 80.67% -0.01%
==========================================
Files 1086 1086
Lines 366691 366829 +138
Branches 366691 366829 +138
==========================================
+ Hits 295832 295934 +102
- Misses 53235 53264 +29
- Partials 17624 17631 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Minor fix I stumbled across. There is no issue (I can create one if this warrants discussion).
Rationale for this change
If the file scan is guaranteed to have no results (
num_rows == Precision::Exact(0)), filtering them does not change the result. It will be zero anyway.What changes are included in this PR?
Only change
Exact->Inexactif there are non-zero rowsAre these changes tested?
Yes.
Are there any user-facing changes?
It can happen that the optimizer can now better optimize the query plans (which we are looking forward to).