test: Fix data_pagesize_limit extraction in parquet writer props roundtrip test#23664
Open
jackylee-ch wants to merge 1 commit into
Open
test: Fix data_pagesize_limit extraction in parquet writer props roundtrip test#23664jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23664 +/- ##
==========================================
- Coverage 80.66% 80.66% -0.01%
==========================================
Files 1086 1086
Lines 366694 366694
Branches 366694 366694
==========================================
- Hits 295806 295794 -12
- Misses 53265 53269 +4
- Partials 17623 17631 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
In the test helper
session_config_from_writer_props,data_pagesize_limitis extracted fromprops.dictionary_page_size_limit()instead ofprops.data_page_size_limit(). The bug is masked becauseparquet_options_with_non_defaultssets both limits to the same value (42), so the roundtrip test cannot catch a mixed-up mapping between these two options.What changes are included in this PR?
data_pagesize_limitfromprops.data_page_size_limit().data_pagesize_limit(42) anddictionary_page_size_limit(43) in the test options so the roundtrip test can detect such mix-ups.Are these changes tested?
Yes, covered by the existing
table_parquet_opts_to_writer_propsroundtrip test. Verified that reverting the extraction fix now makes the test fail.Are there any user-facing changes?
No, test-only change.