perf: Optimize NULL handling in StringViewArrayBuilder#21538
Open
neilconway wants to merge 2 commits intoapache:mainfrom
Open
perf: Optimize NULL handling in StringViewArrayBuilder#21538neilconway wants to merge 2 commits intoapache:mainfrom
StringViewArrayBuilder#21538neilconway wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
FYI @Omega359 |
Omega359
approved these changes
Apr 10, 2026
Contributor
Omega359
left a comment
There was a problem hiding this comment.
I looked this over and it seems reasonable, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
StringViewArrayBuilder#21537.Rationale for this change
StringViewArrayBuilderis implemented on top of Arrow'sStringViewBuilder; the latter tracks NULLs incrementally. However, theStringViewArrayBuilderrequires callers to pass a NULL buffer tofinish()anyway, so the NULL bitmap that has been computed byStringViewBuilderis discarded. It would be more efficient to stop usingStringViewBuilderso that we don't do this redundant work; in theory there might be room for inconsistency between the two NULL bitmaps as well.Right now,
StringViewArrayBuilderis only used by theconcatandconcat_wsUDFs, but I'd like to generalize the API and use it more broadly in place ofStringViewBuilder(#21539). For the time being, here are the results of this PR on theconcatbenchmarks (Arm64):What changes are included in this PR?
StringViewBuilderand build the views ourselvesAre these changes tested?
Yes.
Are there any user-facing changes?
No.