feat: support array_compact builtin function#21522
Open
comphead wants to merge 4 commits intoapache:mainfrom
Open
feat: support array_compact builtin function#21522comphead wants to merge 4 commits intoapache:mainfrom
array_compact builtin function#21522comphead wants to merge 4 commits intoapache:mainfrom
Conversation
github-actions
bot
added
sqllogictest
github-actions
bot
added
the
documentation
Jefffrey
reviewed
Apr 10, 2026
| } | ||
|
|
||
| /// array_compact SQL function | ||
| pub fn array_compact_inner(arg: &[ArrayRef]) -> Result<ArrayRef> { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub fn array_compact_inner(arg: &[ArrayRef]) -> Result<ArrayRef> { | |
| fn array_compact_inner(arg: &[ArrayRef]) -> Result<ArrayRef> { |
| false, | ||
| Capacities::Array(original_data.len()), | ||
| ); | ||
| let mut valid = NullBufferBuilder::new(list_array.len()); |
Contributor
There was a problem hiding this comment.
Can directly grab null buffer from input array for the output array to avoid needing a builder here
| [[1, 2], [3, 4], [5, 6], [7, 8], [9, 10]] | ||
| [[5, 6], NULL] | ||
|
|
||
| ## array_compact (aliases: `list_compact`) |
Contributor
There was a problem hiding this comment.
Should we also add a test for fixedsizelist?
Contributor
Author
|
Thanks @Jefffrey addressed the comments. One thing comes to my mind is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Create
array_compactfunction which removes NULLs from input array. There is no direct counterparty in DuckDB however the function used in Spark, SnowFlakeWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?