Enable arrow-ipc/zstd in datasource-arrow to make test_spill_compression pass in every config#21504
Open
AdamGS wants to merge 1 commit intoapache:mainfrom
Open
Enable arrow-ipc/zstd in datasource-arrow to make test_spill_compression pass in every config#21504AdamGS wants to merge 1 commit intoapache:mainfrom
arrow-ipc/zstd in datasource-arrow to make test_spill_compression pass in every config#21504AdamGS wants to merge 1 commit intoapache:mainfrom
Conversation
AdamGS
changed the title
arrow-ipc/zstd in datasource-arrowarrow-ipc/zstd in datasource-arrow to make test_spill_compression pass in every config
metegenez
reviewed
Apr 10, 2026
Contributor
metegenez
left a comment
metegenez
left a comment
There was a problem hiding this comment.
compression = [] feature becomes dead. It exists, takes no inputs, and does nothing. We should leave a comment saying why it's kept (backcompat for downstream users who wrote features = ["compression"] in their own Cargo.toml).
For architectural point of view, The spill manager still assumes "all codecs are available" without actually checking. can be the problem as well? Is spill manager's codec assumption worth a follow-up issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
test_spill_compressionfails with default features #21503.Rationale for this change
The spill manager assumes that all available compressions are actually available, which currently relies on feature unification with
datafusion-datasource-arrow.What changes are included in this PR?
Move
arrow-ipc/zstdfeature fromdatafusion-datasource-arrowto the workspace dependency, like lz4.Are these changes tested?
Existing tests cover the functionality, tested individual crates locally.
Are there any user-facing changes?
Shifts some features around which might change behavior for users for DataFusion, not sure how the project reasons about this level of changes.