perf: Optimize array set ops on sliced arrays#20693
Open
neilconway wants to merge 3 commits intoapache:mainfrom
Open
perf: Optimize array set ops on sliced arrays#20693neilconway wants to merge 3 commits intoapache:mainfrom
neilconway wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
#20677 is similar, but in that case operating on the full values array leads to a bug. |
Contributor
Author
|
Benchmarks: These benchmarks use a ratio of 10:1 hidden:visible rows. The reason the benchmark results don't show a ~10x speedup is that previously, we did row conversion on the hidden rows but only applied the set operation to the visible rows, so the latter part was not inefficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Several array set operations (
array_union,array_intersect,array_distinct,array_except) operate on all values in the underlying values buffer of aListArraywhen doing batched row conversion. For sliced ListArrays,values()returns the full underlying buffer, which means we end up doing row conversion for rows that aren't in the visible slice. This was not a correctness issue but it is inefficient.What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
AI usage
Multiple AI tools were used to iterate on this PR. I have reviewed and understand the resulting code.