Make translate emit Utf8View for Utf8View input#20624
Open
shivaaang wants to merge 1 commit intoapache:mainfrom
Open
Make translate emit Utf8View for Utf8View input#20624shivaaang wants to merge 1 commit intoapache:mainfrom
shivaaang wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
sqllogictest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #20585
Rationale for this change
String UDFs should preserve string representation where feasible.
translatepreviously accepted Utf8View input but emitted Utf8, causing an unnecessary type downgrade. This alignstranslatewith the expected behavior of returning the same string type as its primary input.What changes are included in this PR?
translatereturn type inference to emit Utf8View when input is Utf8View, while preserving existing behavior for Utf8 and LargeUtf8.translateandtranslate_with_mapto use explicit string builders (via a localTranslateOutputhelper trait) instead of.collect::<GenericStringArray<T>>(), so the correct output array type is produced for each input type.arrow_typeofoutput for all three string types.Are these changes tested?
Yes. Unit tests and sqllogictests are included.
Are there any user-facing changes?
No.