-
Notifications
You must be signed in to change notification settings - Fork 2k
Migrate Python usage to uv workspace #20414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,16 +44,10 @@ jobs: | |
| with: | ||
| submodules: true | ||
| fetch-depth: 1 | ||
| - name: Setup Python | ||
| uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||
| with: | ||
| python-version: "3.12" | ||
| - name: Setup uv | ||
| uses: astral-sh/setup-uv@f0ec1fc3b38f5e7cd731bb6ce540c5af426746bb # v6.1.0 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the specific commit a requirement? I think
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, but it is generally encouraged to lock to commits in GHA: a commit provides an immutable reference to "safe" code. A tag is mutable. If a malicious actor gains control of an action repository they can upload a new v6 and infect everyone. If everyone is pinned to the commit they can't force the malicious code into everyone's CI unless you opt in by updating the hash. TLDR because there are no lockfiles for CI and because CI is a critical vector for supply chain attacks it's best to pin to a hash. |
||
| - name: Install doc dependencies | ||
| run: | | ||
| set -x | ||
| python3 -m venv venv | ||
| source venv/bin/activate | ||
| pip install -r docs/requirements.txt | ||
| run: uv sync --project docs | ||
| - name: Install dependency graph tooling | ||
| run: | | ||
| set -x | ||
|
|
@@ -63,6 +57,5 @@ jobs: | |
| - name: Build docs html and check for warnings | ||
| run: | | ||
| set -x | ||
| source venv/bin/activate | ||
| cd docs | ||
| ./build.sh # fails on errors | ||
| uv run --project ../docs ./build.sh # fails on errors | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| [project] | ||
| name = "datafusion-benchmarks" | ||
| version = "0.1.0" | ||
| requires-python = ">=3.11" | ||
| dependencies = ["rich", "falsa"] |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| [project] | ||
| name = "datafusion-dev" | ||
| version = "0.1.0" | ||
| requires-python = ">=3.11" | ||
| dependencies = ["tomlkit", "PyGithub", "requests"] |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| [project] | ||
| name = "datafusion-docs" | ||
| version = "0.1.0" | ||
| requires-python = ">=3.11" | ||
| dependencies = [ | ||
| "sphinx>=9,<10", | ||
| "sphinx-reredirects>=1.1,<2", | ||
| "pydata-sphinx-theme>=0.16,<1", | ||
| "myst-parser>=5,<6", | ||
| "maturin>=1.11,<2", | ||
| "jinja2>=3.1,<4", | ||
| "setuptools>=82,<83", | ||
| ] |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as below, do we need to specific a specific sha here?