perf: defer expensive string predicates from RowFilter when dynamic filter is present#20413
Closed
notashes wants to merge 1 commit intoapache:mainfrom
Closed
perf: defer expensive string predicates from RowFilter when dynamic filter is present#20413notashes wants to merge 1 commit intoapache:mainfrom
RowFilter when dynamic filter is present#20413notashes wants to merge 1 commit intoapache:mainfrom
Conversation
notashes
force-pushed
the
perf/strings-attached
branch
from
348ec1f to
91a8c5c
Compare
2 tasks
Dandandan
reviewed
Feb 17, 2026
Contributor
Author
|
closed in favour of #20417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When
pushdown_filters=trueand a TopK dynamic filter is present alongside a col != literal on a string/binary column, the string predicate's decode cost through the predicate cache blocks the dynamic filter from converging. this causes regression in Q24 for instance.What changes are included in this PR?
when dynamic filters are detected we defer
col != literalfor string/binary types.Are these changes tested?
Yes. I have added
test_dynamic_filter_defers_string_predicatebut it's more of a correctness test as if we actually want to measure if the filter was deferred we'd need to rely on metrics.Are there any user-facing changes?