refactor: Set expected runtime config in error message when the used disk space during the spilling process has exceeded the allocation limit#20375
Open
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Conversation
… during the spilling process has exceeded the allocation limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Minor refactoring on error message by exposing required config name for the end user. This is follow-up PR to both PR: #20226 and #20372 by runtime config:
datafusion.runtime.max_temp_directory_size.What changes are included in this PR?
Current:
New:
Are these changes tested?
Yes, legacy UT case has been updated by covering expected config name.
Are there any user-facing changes?
Yes, error message has been updated which is exposed to end-users.