Skip to content

completed_groups_release_first_value_bitmap takes 10 minutes under force_hash_collisions #27033

Closed

Description

@kumarUjjawal

Is your feature request related to a problem or challenge?

aggregates::clustered_partial_stream::tests::completed_groups_release_first_value_bitmap (added in #26782) takes about 10 minutes in the cargo test hash collisions (amd64) merge-queue job. Without force_hash_collisions, it takes about 1 second.

The test aggregates 131,072 distinct Int64 keys in one batch. Under force_hash_collisions, GroupValuesPrimitive gives every key the hash 0, so each insert compares against all earlier keys. The test also runs the plan two times (without a limit and with a 16 KB limit).

The test checks that FIRST_VALUE(v ORDER BY v) releases its per-batch bitmap. Colliding hashes do not change what it checks.

Evidence from merge-queue runs:

Locally (--profile ci, single test), it takes 0.92s by default and 309s with force_hash_collisions.

Describe the solution you'd like

Skip the test under force_hash_collisions, as #26594 did for sort_after_group_by_reserves_shared_output_once. The regular cargo test job still runs it.

Describe alternatives you've considered

Use fewer groups with a lower memory limit. This keeps the test in the hash-collision job, but the bitmap must still be larger than what the active group needs, so it is a call for the test's author.

Additional context

Related to #26759.

Activity

  1. added a commit that references this issue on Nov 3, 2026
    7d7d6b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions