Repository navigation
PostgreSQL: Escape quotes in COMMENT ON values - #2783
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 42 42
Lines 35968 35968
Branches 35968 35968
=======================================
Hits 29807 29807
Misses 2654 2654
Partials 3507 3507 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
comment-on-escape-quotes
branch
from
October 31, 2026 19:09
82fe2d6 to
ac2060c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMMENT ON COLUMN t.id IS 'Column ''id'' on t'rendered asCOMMENT ON COLUMN t.id IS 'Column 'id' on t', which does not parse. The value is now printed throughescape_single_quote_string. Hopefully there are not many of these still in the codebase, I am trying to find the last ones. Of course, there is an argument to turnescape_single_quote_stringto awrite_escape_single_quote_stringto avoid the allocation, but I will tackle that separately.https://www.postgresql.org/docs/current/sql-comment.html