Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dialect/duckdb.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,4 +142,8 @@ impl Dialect for DuckDbDialect {
fn supports_numeric_literal_underscores(&self) -> bool {
true
}

fn supports_string_escape_constant(&self) -> bool {
true
}
}
5 changes: 2 additions & 3 deletions src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1965,8 +1965,7 @@ impl<'a> Parser<'a> {
),
})
}
Token::EscapedStringLiteral(_) if dialect_is!(dialect is PostgreSqlDialect | GenericDialect) =>
{
Token::EscapedStringLiteral(_) if self.dialect.supports_string_escape_constant() => {
self.prev_token();
Ok(Expr::Value(self.parse_value()?))
}
Expand Down Expand Up @@ -12669,7 +12668,7 @@ impl<'a> Parser<'a> {
}) => Ok(value),
Token::SingleQuotedString(s) => Ok(s),
Token::DoubleQuotedString(s) => Ok(s),
Token::EscapedStringLiteral(s) if dialect_of!(self is PostgreSqlDialect | GenericDialect) => {
Token::EscapedStringLiteral(s) if self.dialect.supports_string_escape_constant() => {
Ok(s)
}
Token::UnicodeStringLiteral(s) => Ok(s),
Expand Down
38 changes: 37 additions & 1 deletion tests/sqlparser_duckdb.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ use sqlparser::tokenizer::Span;
use test_utils::*;

use sqlparser::ast::*;
use sqlparser::dialect::{DuckDbDialect, GenericDialect};
use sqlparser::dialect::{AnsiDialect, DuckDbDialect, GenericDialect};
use sqlparser::parser::ParserError;

fn duckdb() -> TestedDialects {
Expand Down Expand Up @@ -910,3 +910,39 @@ fn test_duckdb_lambda_function() {
let sql_transform = "SELECT list_transform([1, 2, 3], lambda x : x * 2)";
duckdb().verified_stmt(sql_transform);
}

#[test]
fn test_escape_string_literal() {
duckdb().verified_stmt(r#"SELECT E'a\nb' AS value"#);

assert_eq!(
duckdb().verified_expr(r#"E'a\nb'"#),
Expr::Value((Value::EscapedStringLiteral("a\nb".to_string())).with_empty_span())
);
assert_eq!(
duckdb().verified_expr(r#"'a\nb'"#),
Expr::Value((Value::SingleQuotedString(r#"a\nb"#.to_string())).with_empty_span())
);
duckdb().one_statement_parses_to(
r#"COPY data TO E'out\n.csv'"#,
r#"COPY data TO 'out
.csv'"#,
);

let err = duckdb()
.parse_sql_statements("SELECT E'unterminated")
.unwrap_err();
assert_eq!(
err,
ParserError::TokenizerError(
"Unterminated encoded string literal at Line: 1, Column: 8".to_string()
)
);

let ansi = TestedDialects::new(vec![Box::new(AnsiDialect {})]);
assert_eq!(
ansi.parse_sql_statements(r#"SELECT E'a\nb' AS value"#)
.unwrap_err(),
ParserError::ParserError("Expected: end of statement, found: AS".to_string())
);
}