Skip to content

Make visitor feature no_std-compatible#2343

Open
LucaCappelletti94 wants to merge 2 commits into
apache:mainfrom
LucaCappelletti94:visitor-wasm
Open

Make visitor feature no_std-compatible#2343
LucaCappelletti94 wants to merge 2 commits into
apache:mainfrom
LucaCappelletti94:visitor-wasm

Conversation

@LucaCappelletti94
Copy link
Copy Markdown
Contributor

@LucaCappelletti94 LucaCappelletti94 commented May 20, 2026

Enabling the visitor feature without std (e.g. default-features = false, features = ["visitor"] on wasm32-unknown-unknown) currently fails with ~3200 errors. The Visit / VisitMut derive in sqlparser_derive hard-codes ::std::ops::ControlFlow in the generated impls, and src/ast/visitor.rs references String / Vec / Box without importing them from alloc, so neither path resolves once the crate root evaluates #![no_std].

The existing compile-no-std CI job is extended with a --features visitor cargo check on thumbv6m-none-eabi so this regression cannot land silently again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant