Fix STORAGE LIFECYCLE POLICY for snowflake queries#2264
Open
romanoff wants to merge 2 commits intoapache:mainfrom
Open
Fix STORAGE LIFECYCLE POLICY for snowflake queries#2264romanoff wants to merge 2 commits intoapache:mainfrom
romanoff wants to merge 2 commits intoapache:mainfrom
Conversation
iffyio
reviewed
Mar 9, 2026
src/ast/ddl.rs
Outdated
| /// Snowflake "WITH ROW ACCESS POLICY" clause | ||
| /// <https://docs.snowflake.com/en/sql-reference/sql/create-table> | ||
| pub with_row_access_policy: Option<RowAccessPolicy>, | ||
| /// Snowflake "WITH STORAGE LIFECYCLE POLICY" clause |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Snowflake "WITH STORAGE LIFECYCLE POLICY" clause | |
| /// Snowflake `WITH STORAGE LIFECYCLE POLICY` clause |
tests/sqlparser_snowflake.rs
Outdated
Comment on lines
+310
to
+312
| .parse_sql_statements( | ||
| "CREATE TABLE my_table (a NUMBER(38,0)) STORAGE LIFECYCLE POLICY my_policy ON (a, b)", | ||
| ) |
Contributor
There was a problem hiding this comment.
can we use one_statement_parses_to to assert what this statement is displayed as?
Contributor
Author
|
@iffyio Updated. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample query:
Spec: https://docs.snowflake.com/en/sql-reference/sql/create-table