Describe the bug
During the vote on the Apache DataFusion sqlparser-rs 0.63.0 RC1 release, @Xuanwo identified two licensing-material issues in the source archive and voted -1 (non-binding): https://lists.apache.org/thread/3lnhgs0bwzl148yrdrcl5g005h9pgtmx
- Missing
NOTICE file: the source archive contains LICENSE.TXT but no NOTICE file, which ASF releases are expected to include.
sqlparser_bench/img/flamegraph.svg embeds third-party licensed code: the generated flamegraph embeds JavaScript from Inferno, whose upstream license is CDDL 1.0, but the archive contains no corresponding license materials.
To Reproduce
Download and unpack the 0.63.0 RC1 source archive (or check the repository at v0.63.0-rc1):
$ ls NOTICE*
ls: NOTICE*: No such file or directory
$ grep -c -i inferno sqlparser_bench/img/flamegraph.svg
2
Expected behavior
The source release complies with ASF licensing policy:
- Add a
NOTICE file to the repository so it is included in source archives.
- Exclude the generated
sqlparser_bench/img/flamegraph.svg from the source release
Additional context
Describe the bug
During the vote on the Apache DataFusion sqlparser-rs
0.63.0RC1 release, @Xuanwo identified two licensing-material issues in the source archive and voted -1 (non-binding): https://lists.apache.org/thread/3lnhgs0bwzl148yrdrcl5g005h9pgtmxNOTICEfile: the source archive containsLICENSE.TXTbut noNOTICEfile, which ASF releases are expected to include.sqlparser_bench/img/flamegraph.svgembeds third-party licensed code: the generated flamegraph embeds JavaScript from Inferno, whose upstream license is CDDL 1.0, but the archive contains no corresponding license materials.To Reproduce
Download and unpack the 0.63.0 RC1 source archive (or check the repository at
v0.63.0-rc1):Expected behavior
The source release complies with ASF licensing policy:
NOTICEfile to the repository so it is included in source archives.sqlparser_bench/img/flamegraph.svgfrom the source releaseAdditional context