Skip to content

Fix licensing issues in source release found during 0.63.0 RC1 vote (missing NOTICE file, flamegraph.svg with CDDL-licensed JavaScript) #2495

Description

@alamb

Describe the bug

During the vote on the Apache DataFusion sqlparser-rs 0.63.0 RC1 release, @Xuanwo identified two licensing-material issues in the source archive and voted -1 (non-binding): https://lists.apache.org/thread/3lnhgs0bwzl148yrdrcl5g005h9pgtmx

  1. Missing NOTICE file: the source archive contains LICENSE.TXT but no NOTICE file, which ASF releases are expected to include.
  2. sqlparser_bench/img/flamegraph.svg embeds third-party licensed code: the generated flamegraph embeds JavaScript from Inferno, whose upstream license is CDDL 1.0, but the archive contains no corresponding license materials.

To Reproduce

Download and unpack the 0.63.0 RC1 source archive (or check the repository at v0.63.0-rc1):

$ ls NOTICE*
ls: NOTICE*: No such file or directory

$ grep -c -i inferno sqlparser_bench/img/flamegraph.svg
2

Expected behavior

The source release complies with ASF licensing policy:

  1. Add a NOTICE file to the repository so it is included in source archives.
  2. Exclude the generated sqlparser_bench/img/flamegraph.svg from the source release

Additional context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions