docs(example): quarantine foreign plan workaround - #1733
Open
akashchamp wants to merge 1 commit into
Open
Conversation
Move the temporary execution-plan token registry into a deliberately named module and document its process-local behavior and removal criteria. Signed-off-by: Akash Kumar <116457960+akashchamp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1725
Rationale for this change
The FFI example needs a temporary process-local registry to preserve an opaque
ForeignExecutionPlan wrapper. Keeping that workaround beside the general
physical codec makes its broad claim and non-portable payload look reusable.
What changes are included in this PR?
foreign_plan_workaround module.
and record the removal conditions.
and take operations to the isolated module.
How are these changes tested?
then serialized and restored a physical plan through MyPhysicalExtensionCodec.
lock validation passed. The workflow hook could not run because the remote
host has no Docker daemon, and the project's nightly rustfmt hook could not
be installed because the Rust distribution endpoint timed out. The stable
cargo fmt --all -- --check command passed.
No new test is needed because this keeps the codec behavior intact; the focused
test and the manual round-trip exercise the delegated encode/decode path.