feat: native RANGE window frames with explicit offset on DATE ORDER BY#4974
Open
0lai0 wants to merge 5 commits into
Open
feat: native RANGE window frames with explicit offset on DATE ORDER BY#49740lai0 wants to merge 5 commits into
0lai0 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4834 (DATE ORDER BY only; DECIMAL remains a follow-up)
Rationale for this change
Native windows used to fall back to Spark for
RANGEframes with an explicitPRECEDING/FOLLOWINGoffset whenORDER BYwasDATE. Spark ships that offset as an integer literal, but arrow-arith rejectsDate32 + Int32and requires anIntervalRHS.This PR coerces the offset to
IntervalDayTimewhen the ORDER BY column isDate32, so boundary math usesDate32 + IntervalDayTimeand the DATE fallback can be removed.UNBOUNDED/CURRENT ROWalready ran natively; DECIMAL still falls back.What changes are included in this PR?
Int32/Int64RANGE offsets toIntervalDayTimeforDate32ORDER BY.DateTypeRANGE fallback; keep the DECIMAL fallback.CometWindowExecSuite(offsets, duplicate dates, nulls, unbounded baseline).How are these changes tested?
./mvnw test -Dtest=none -Dsuites="org.apache.comet.exec.CometWindowExecSuite"