Skip to content

feat: Support Spark expression: convert_timezone#4369

Merged
comphead merged 7 commits into
apache:mainfrom
YutaLin:3132_spark_expression_convert_timezone
May 20, 2026
Merged

feat: Support Spark expression: convert_timezone#4369
comphead merged 7 commits into
apache:mainfrom
YutaLin:3132_spark_expression_convert_timezone

Conversation

@YutaLin
Copy link
Copy Markdown
Contributor

@YutaLin YutaLin commented May 20, 2026

Which issue does this PR close?

Closes #3132

Rationale for this change

Support expression convert_timezone

What changes are included in this PR?

Leverage native function SparkFromUtcTimestamp and SparkToUtcTimestamp so only add CometConvertTimezone in datatime.scala

How are these changes tested?

Add convert_timezone.sql and run test in Spark 3.4/3.5/4.0 and linter check

@YutaLin
Copy link
Copy Markdown
Contributor Author

YutaLin commented May 20, 2026

Hi @andygrove,
Thanks for the review, I've added test case for Null source / target tz.

@YutaLin YutaLin requested a review from andygrove May 20, 2026 15:39
Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YutaLin

@comphead
Copy link
Copy Markdown
Contributor

comphead commented May 20, 2026

Thanks @YutaLin
We also currently testing the Claude skill wire_datafusion_function which knows about how tests should be built, appreciate if you can try it, share feedback and improve if needed

@comphead comphead merged commit 2e8cc34 into apache:main May 20, 2026
125 checks passed
@YutaLin YutaLin deleted the 3132_spark_expression_convert_timezone branch May 20, 2026 17:30
@YutaLin
Copy link
Copy Markdown
Contributor Author

YutaLin commented May 20, 2026

Hi @comphead
Thanks for the merge and feedback, i will try it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support Spark expression: convert_timezone

3 participants