docs: remove references to native_datafusion and native_iceberg_compat scans#4362
Merged
mbutrovich merged 5 commits intoMay 19, 2026
Merged
Conversation
…-references # Conflicts: # docs/source/contributor-guide/bug_triage.md
Comment on lines
+150
to
+154
| | `CometScan` | V1 Parquet scan driven by Spark's file-source path through Comet's Parquet reader. Decoding runs in native code; the resulting Arrow batches cross JNI into the native plan. | | ||
| | `CometBatchScan` | DataSource V2 scan, including Iceberg Parquet, that produces Arrow batches consumed by Comet. | | ||
| | `CometNativeScan` | Fully native Parquet scan that runs entirely in DataFusion (no JVM Parquet reader involvement). | | ||
| | `CometIcebergNativeScan` | Fully native Iceberg Parquet scan. | | ||
| | `CometCsvNativeScan` | Fully native CSV scan (experimental). | |
Contributor
There was a problem hiding this comment.
Do we still see these scan types? Or are these for the case users set the deprecated scan type?
Member
Author
There was a problem hiding this comment.
CometScan should no longer appear. I will update this.
mbutrovich
reviewed
May 19, 2026
mbutrovich
approved these changes
May 19, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
I think this looks right. I can take another pass as we review all the docs for 1.0.0, but for now this is good. Thanks @andygrove!
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4020.
Rationale for this change
Companion docs update to #4019. Once
native_iceberg_compatis removed and Comet has a single Parquet scan implementation, references to the two named impls (native_datafusion,native_iceberg_compat) and thespark.comet.scan.implselection mechanic become misleading. This PR strips those references from the user guide and contributor guide so the docs match the post-#4019 reality.What changes are included in this PR?
compatibility/scans.md: flattened to a single "Parquet Scan Limitations" section; impl comparison table andspark.comet.scan.implparagraph removed; shared +native_datafusionlimitations merged;native_iceberg_compatlimitation dropped.compatibility/spark-versions.md: per-version notes now refer to "Comet's Parquet scan"; anchor links retargeted to#parquet-scan-limitations.compatibility/index.md: dropped the "(both scan implementations, …)" parenthetical.user-guide/latest/datasources.md: S3 section rephrased for a single scan;--conf spark.comet.scan.impl=native_datafusionremoved from the HDFS example and the two S3 examples; the HDFS Scala snippet'sCOMET_NATIVE_SCAN_IMPLline removed.user-guide/latest/understanding-comet-plans.md: removed the "active scan implementation is shown in brackets" note fromCometScan.contributor-guide/adding_a_new_spark_version.md: droppedscan_impl: "auto"guidance, removedspark_sql_test_native_iceberg_compat.yml, droppedscan-implfrom the matrix list.contributor-guide/bug_triage.md: removed the two impl labels from the area-label list and reworded the "core path over experimental" principle.Changelog and versioned-snapshot files under
docs/source/changelog/anddocs/comet-0.16/are intentionally untouched.How are these changes tested?
Docs-only change. Verified that no active docs file under
docs/source/(excludingchangelog/) referencesnative_datafusion,native_iceberg_compat,spark.comet.scan.impl,COMET_NATIVE_SCAN_IMPL, orSCAN_NATIVE_DATAFUSION.