feat: detect Iceberg V2 writes and emit fall-back reasons#4323
Open
jordepic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4322.
Rationale for this change
Eventually we need to support writes from DataFusion. This is essential for avoiding an expensive transformation from columnar to row-wise data and keeping all operations in native code!
What changes are included in this PR?
This change is purely scaffolding. My hope is to get feedback from @mbutrovich and @andygrove about my approach before diving deeper. I have confirmed that this particular spec is very doable in Comet, but I want to agree on the interface of what Comet will support before going in further.
How are these changes tested?
I have unit tests in this commit devoted towards recognizing which operators can be converted by comet as well as scenarios under which we'll fall back to typical JVM data writing.