fix(android): Fixes Samsung Galaxy S5 cancelling on touch outside#60
Open
scheinem wants to merge 1 commit intoapache:masterfrom
SRBConsultingTeam:master
Open
fix(android): Fixes Samsung Galaxy S5 cancelling on touch outside#60scheinem wants to merge 1 commit intoapache:masterfrom SRBConsultingTeam:master
scheinem wants to merge 1 commit intoapache:masterfrom
SRBConsultingTeam:master
Conversation
janpio
changed the title
janpio
requested changes
Jul 4, 2019
Member
janpio
left a comment
janpio
left a comment
There was a problem hiding this comment.
Code indentation is wrong here, source repository is unfortunately not available any more to fix. This would probably have to be checked if still necessary and then re-implemented in a new PR.
Author
|
Sorry. I've deleted the forked repo after two years without any activity on this pull request. If I can help you to get this through, please let me know. |
Member
|
Don't worry, the review was just to make sure this isn't merged by accident and that we have documentation what has to happen to get this in a mergable state. If you want you can create the new PR based on the current codebase again (and then close this one). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Samsung Galaxy S5 (tested on Android 5.0) a touch outside the AlertDialog won't make it disappear without this line of code added.