fix(toc): highlight toc entries pointing to index.html#1471
Merged
Conversation
- Fix an issue where menu entries weren't being highlighted or scrolled to when navigating between documentation pages, particularly affecting nested entries without children (e.g., "Security" under "Security & Privacy"). - Normalize URLs to handle Jekyll's pretty URLs (e.g., "path/") vs TOC entry URLs (e.g., "path/index.html") for proper comparison - Add validation to prevent false matches on pages without URLs - Fixes: #1417 - Generated-By: Claude Sonnet 4.5
- It's enough to just replace `index.html` with an empty string
- This is used on mobile devices. Since the css is not properly configured for the dropdown the highlighting cannot be seen
Contributor
Author
|
This is ready to review |
erisu
approved these changes
Feb 18, 2026
Member
erisu
left a comment
There was a problem hiding this comment.
LGTM, this resolved the issue the same way I was expecting to resolve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path/vs TOC entry URLs likepath/index.htmlfor proper comparisontoc_recursive_main.htmland Mobiletoc_recursive_dropdown.html. On mobile this cannot visually be seen, since the css is not properly configured for the dropdown. This will be fixed with fix(toc): apply highlighting to mobile design #1472.Platforms affected
Motivation and Context
Description
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))