LANG-1386

[ester-bloch]

Ambiguous method call error when using BooleanUtils.and

[garydgregory]

Hello @ester-bloch

-1 as this PR stands: It breaks the build and does not wholly resolve LANG-1386.

You must run mvn locally by itself before you push to a PR, as described in the PR template.

The following methods are in play:

• BooleanUtils.and(boolean...)
• BooleanUtils.and(Boolean...)
• BooleanUtils.oneHot(boolean...)
• BooleanUtils.oneHot(Boolean...)
• BooleanUtils.or(boolean...)
• BooleanUtils.or(Boolean...)
• BooleanUtils.xor(boolean...)
• BooleanUtils.xor(Boolean...)

The main question IMO is: Should we:

• Do nothing, or
• Change the primitive... vararg parameter to [], or
• Change the Object... vararg parameter arg to []

?

• Changing the primitive... arg to [] means both new tests compile to the Object API.
• Changing the Object... arg to [] means both new tests compile to the primitive API.

Whatever is changed, if anything is changed, needs to be consistent and documented.

Obviously, we cannot break binary compatibility.

[isachinshah]

We should keep this as final.
We will not be allowed to modify the reference and work with another array by mistake.
Otherwise we will be busy debugging why our changes are not persisted/reflected after the method call.