Harden XML parsing via commons-secure-xml - #289
Draft
ppkarwasz wants to merge 1 commit into
Draft
Conversation
Create SAX parser and document builder factories through org.apache.commons:commons-secure-xml. The secure factories enable FEATURE_SECURE_PROCESSING and install a non-removable entity-resolver floor on every parser they produce: external DTD, entity, schema and XInclude lookups that a caller-set resolver does not resolve are resolved to empty content instead of being fetched, and internal entity expansion is bounded, regardless of the JAXP implementation on the classpath. Changes: - Add the commons-secure-xml dependency (1.0.0-SNAPSHOT until its first release) to commons-digester3-core. - Route factory creation through SecureSAXParserFactory in Digester.getFactory() and DigesterLoader, and through SecureDocumentBuilderFactory in NodeCreateRule. The caller-facing configuration (namespace and XInclude awareness, validation, schema, features and properties) keeps working, and getFactory() still returns a plain SAXParserFactory. - Digester itself acts as the entity resolver of the readers it creates, and resolvers installed by the caller keep precedence over the floor, so registered entities, relative DTDs and DTD validation resolve exactly as before; the floor only takes effect for parsers whose resolver chain leaves a lookup unresolved. - Callers supplying their own SAXParser or XMLReader (constructors and DigesterLoader.newDigester overloads) keep full control of their parser configuration. - Run the CI and CodeQL builds with -Puse-apache-snapshots (inherited from the org.apache:apache parent POM) so the commons-secure-xml SNAPSHOT resolves; CodeQL's autobuild receives the profile through MAVEN_ARGS. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MHgnMnGWHQoH2zD2jFdoMT
ppkarwasz
force-pushed
the
feat/use-commons-xml
branch
from
August 31, 2026 15:09
846b7a6 to
ccd7f6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR was submitted automatically to smoke-test
Apache Commons Secure XML
and has not yet been verified by a human.
It will stay a draft until a committer reviews it and marks it ready.
Creates SAX parser and document builder factories through
org.apache.commons:commons-secure-xml(1.0.0-SNAPSHOT until its first release) incommons-digester3-core. The secure factories enable XML secure processing and install a non-removable entity-resolver floor: external DTD, entity, schema and XInclude lookups that a caller-set resolver does not resolve are resolved to empty content instead of being fetched, and internal entity expansion is bounded.Digester.getFactory()andDigesterLoadergo throughSecureSAXParserFactory,NodeCreateRulethroughSecureDocumentBuilderFactory. The caller-facing configuration (namespace and XInclude awareness, validation, schema, features and properties) keeps working, andgetFactory()still returns a plainSAXParserFactory.Digesteritself acts as the entity resolver of the readers it creates, and resolvers installed by the caller keep precedence over the floor, so registered entities, relative DTDs and DTD validation resolve exactly as before; the floor only takes effect for parsers whose resolver chain leaves a lookup unresolved. All DTD-validation, entity-resolution, XInclude and schema tests pass unchanged.SAXParserorXMLReaderkeep full control of their parser configuration.-Puse-apache-snapshotsso the SNAPSHOT dependency resolves.🤖 Generated with Claude Code