COLLECTIONS-770 When creating an iterator chain containing other iterator chains flatten the resulting internal object.#308
Open
stevebosman-oc wants to merge 2 commits intoapache:masterfrom
Conversation
…ator chains flatten the resulting internal object.
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
============================================
+ Coverage 85.87% 85.88% +0.01%
- Complexity 4676 4683 +7
============================================
Files 292 292
Lines 13469 13482 +13
Branches 1955 1959 +4
============================================
+ Hits 11566 11579 +13
Misses 1326 1326
Partials 577 577
Continue to review full report at Codecov.
|
…ator chains flatten the resulting internal object. Fix checkstyle issues
Claudenw
requested changes
Mar 22, 2023
Contributor
Claudenw
left a comment
Claudenw
left a comment
There was a problem hiding this comment.
The test code does not duplicate the code in the bug report COLLECTIONS-770 nor the closely related COLLECTIONS-722. I would like to see both implemented if possible.
Comment on lines
+194
to
+198
| try { | ||
| iteratorChainOfChains.next(); | ||
| } catch (final Exception e) { | ||
| assertEquals("NoSuchElementException must be thrown", e.getClass(), NoSuchElementException.class); | ||
| } |
Contributor
There was a problem hiding this comment.
Replace this with assertThrows()
Comment on lines
+217
to
+221
| try { | ||
| iteratorChainOfChains.next(); | ||
| } catch (final Exception e) { | ||
| assertEquals("NoSuchElementException must be thrown", e.getClass(), NoSuchElementException.class); | ||
| } |
Contributor
There was a problem hiding this comment.
Replace this with assertThrows()
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributed on behalf of the @opencastsoftware open source team
I am slightly wary of opening up UnmodifiableIterator, but this seems to solve the performance degradation of nested IteratorChains seen in COLLECTIONS-770