Skip to content

[CODEC-347] Handle names emptied during Match Rating Approach cleaning #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 2 commits into from
Oct 18, 2026
Merged

[CODEC-347] Handle names emptied during Match Rating Approach cleaning #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c78d871
CODEC-347 Handle names emptied during MRA cleaning
AryanRG Oct 17, 2026
36f838e
Remove fix action for CODEC-347 from changes.xml
garydgregory Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,11 @@ public boolean isEncodeEquals(String name1, String name2) {
name1 = cleanName(name1);
name2 = cleanName(name2);

// Bulletproof if a name becomes empty after cleanName(name), consistent with encode(String)
if (name1.isEmpty() || name2.isEmpty()) {
return false;
}

// Actual MRA Algorithm

// 1. Remove vowels
Expand Down
11 changes: 11 additions & 0 deletions src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,17 @@ final void testIsEncodeEqualsSecondNameJust1Letter_ReturnsFalse() {
assertFalse(getStringEncoder().isEncodeEquals("test", "t"));
}

@Test
final void testIsEncodeEquals_CornerCase_NameEmptyAfterCleaning_ReturnsFalse() {
// Names that become empty after cleanName(String), consistent with encode(String) returning "".
assertFalse(getStringEncoder().isEncodeEquals("--", "Smith"));
assertFalse(getStringEncoder().isEncodeEquals("Smith", "--"));
assertFalse(getStringEncoder().isEncodeEquals(".,-", "Smith"));
assertFalse(getStringEncoder().isEncodeEquals(" ", "Smith"));
assertFalse(getStringEncoder().isEncodeEquals("Smith", " "));
assertFalse(getStringEncoder().isEncodeEquals("--", ".,"));
}

@Test
final void testIsVowel_CapitalA_ReturnsTrue() {
assertTrue(getStringEncoder().isVowel("A"));
Expand Down
Loading