fix range checks bypassed by wraparound in number converters - #439
Open
rootvector2 wants to merge 1 commit into
Open
fix range checks bypassed by wraparound in number converters#439rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
the byte/short/integer/long branches of NumberConverter.toNumber and the integer locale converters compared longValue()/doubleValue() of the source, which wrap for BigInteger/BigDecimal and round at the 2^63 boundary for double, letting out-of-range values convert to wrong in-range results (2^63 becomes Long.MIN_VALUE, 2^64 + 5 becomes 5); compare the exact value as BigDecimal before narrowing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the range checks in
NumberConverter.toNumber(Class, Number)and in the byte/short/integer/long locale converters run onlongValue()/doubleValue()of the source, butlongValue()of aBigIntegerorBigDecimalkeeps only the low-order 64 bits and adoublecannot represent 2^63 - 1, so out-of-range values wrap or round into range and convert to unrelated results (BigInteger2^63 becomesLong.MIN_VALUE, 2^64 + 5 becomesInteger5, and a locale-parsed"9223372036854775808"is clamped toLong.MAX_VALUE); found while checking the bounds from #404 against boundary values, fixed by comparing the exact value asBigDecimalbefore narrowing.mvn; that'smvnon the command line by itself.