Propagate runtime-visible flag when parsing parameter annotations#509
Merged
garydgregory merged 1 commit intoJun 25, 2026
Merged
Conversation
parameter annotations and nested annotation values were read with a hardcoded isRuntimeVisible=false, so a RuntimeVisibleParameterAnnotations attribute parsed as invisible and a MethodGen round-trip rewrote it as RuntimeInvisibleParameterAnnotations. Thread the flag from the attribute through ParameterAnnotationEntry and AnnotationEntry.read, matching Annotations.
garydgregory
changed the title
Member
|
Merged, ty @rootvector2 |
garydgregory
added a commit
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parameter annotations and nested annotation values were parsed with a hardcoded
falseruntime-visible flag, so aRuntimeVisibleParameterAnnotationsattribute reportedisRuntimeVisible() == falseand aMethodGenround-trip (after the parameter annotations are unpacked) silently rewrote it asRuntimeInvisibleParameterAnnotations, dropping it from runtime reflection; thread the flag from the attribute intoParameterAnnotationEntryand fromAnnotationEntry.readinto nested annotation values, matching whatAnnotationsalready does for field and method annotations.