UI: allow memory setting in flex compute offering in GiB with unit selector (#14082) by saurabhkushwaha438 · Pull Request #14413 · apache/cloudstack

saurabhkushwaha438 · 2026-10-16T05:08:51Z

Description

Fixes #14082

1. Conversion from MiB to GiB (Display & Rounding)

Binary conversion is used (1 GiB = 1024 MiB).
When offerings with predefined constraints or initial values are loaded in MiB, or when switching from MiB to GiB:
$$\text{displayValue} = \text{parseFloat}\left(\left(\frac{\text{rawMemory}}{1024}\right)\text{.toFixed(2)}\right)$$
The display value is rounded to 2 decimal places to keep the UI clean, readable, and intuitive for users.
Slider step dynamically adjusts:
- In GiB mode: step is set to 0.01 (or smaller for sub-GiB offerings) with precision 2.
- In MiB mode: step is set to 1 with integer precision 0.

2. Conversion from GiB to MiB (Backend Value Emission)

CloudStack APIs and backend services expect memory allocations in integer MiB.
When the user selects or inputs memory in GiB:
$$\text{memoryInMiB} = \text{Math.round}(\text{displayValue} \times 1024)$$
Exact Boundary Protection: If a compute offering has minimum/maximum memory constraints (minMemory / maxMemory), selecting the exact minimum or maximum bound in GiB directly maps to the exact integer minMemory or maxMemory in MiB to eliminate any potential off-by-one rounding discrepancies.

💬 Feedback Needed: Fractional GiB to Integer MiB Rounding

Observation: Converting decimal GiB values to MiB often produces fractional values (e.g., 1.51 GiB × 1024 = 1546.24 MiB).
Current Behavior: The UI rounds this to the nearest integer (1546 MiB), which is then emitted in the API payload and consumed by backend hypervisor managers.
Reviewer Input: Looking for maintainer feedback on whether standard nearest-integer rounding (Math.round) is acceptable, or if we should apply ceiling (Math.ceil) to guarantee the VM always receives at least the requested GiB amount.

bandicam.2026-10-16.10-21-12-210.mp4

codecov · 2026-10-29T16:39:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.76%. Comparing base (7ed0cec) to head (6c3f959).
⚠️ Report is 82 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14413      +/-   ##
============================================
+ Coverage     19.91%   20.76%   +0.84%     
- Complexity    20198    21904    +1706     
============================================
  Files          6373     6496     +123     
  Lines        577230   591647   +14417     
  Branches      70696    72601    +1905     
============================================
+ Hits         114936   122835    +7899     
- Misses       449736   455482    +5746     
- Partials      12558    13330     +772

Flag	Coverage Δ
uitests	`3.87% <ø> (+0.16%)`	⬆️
unittests	`22.07% <ø> (+0.88%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nvazquez · 2026-10-30T01:33:52Z

@blueorangutan ui

blueorangutan · 2026-10-30T01:35:04Z

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-10-30T01:56:51Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14413 (QA-JID-1003)

Damans227 · 2026-10-30T17:10:47Z

@blueorangutan ui

blueorangutan · 2026-10-30T17:12:05Z

@Damans227 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-10-30T17:33:42Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14413 (QA-JID-1004)

nvazquez · 2026-11-01T17:43:57Z

@blueorangutan ui

blueorangutan · 2026-11-01T17:45:04Z

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-11-01T18:07:02Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14413 (QA-JID-1005)

nvazquez

Hi @saurabhkushwaha438 I have tested it and I see a problem with custom unconstrained offerings as displayed in the screenshot, can you please take a look at this issue? Custom constrained is looking fine btw.

…B step (apache#14082) - Add compact unit selector dropdown (GiB/MiB) for flex compute offerings - Use fixed 0.25 GiB steps in GiB mode (binary-exact to 256 MiB intervals, zero rounding errors) - Maintain integer MiB as authoritative internal state to prevent lossy conversion on load - Default to GiB for 256 MiB multiples and MiB for arbitrary sizes (e.g. 1500 MiB) - Add hover tooltip to display exact converted values

saurabhkushwaha438 · 2026-11-02T07:16:16Z

Hi @saurabhkushwaha438 I have tested it and I see a problem with custom unconstrained offerings as displayed in the screenshot, can you please take a look at this issue? Custom constrained is looking fine btw.

its done

suryag1201 · 2026-11-02T14:13:36Z

        return
      }
-      this.$emit('update-compute-memory', this.memoryInputDecorator, value)
+      let memoryInMiB
+      if (this.memoryUnit === 'GiB') {


@saurabhkushwaha438 The memory field and its hover text show different amounts of memory value at the minimum and maximum of a constrained offering.
With min memory 100 MiB, the GiB control shows 0.25 GiB. Hovering it shows "Exact: 0.09765625 GiB (100 MiB)", and deploy sends 100 MiB. 0.25 GiB is 256 MiB, so the VM is created with a smaller size than the field shows. The same happens at the maximum.

suryag1201 · 2026-11-02T14:24:57Z

@@ -57,23 +57,40 @@
        </a-col>
        <a-col :md="colContraned" :lg="colContraned" v-if="isCustomized">
          <a-form-item
-            :label="$t('label.memory.mb')"
+            :label="$t('label.memory')"


@saurabhkushwaha438 An out-of-range GiB value is rejected with "Invalid memory value, specify a value between 32 and 2147483647" and the message does not say the unit (MiB or GiB).
For example: 0.01 GiB is sent as 10 MiB and hits this error.

i think you can raise separate issue for that

suryag1201 · 2026-11-02T14:54:44Z

    },
    validateInput (input, value) {
      this.errors[input].status = ''
      this.errors[input].message = ''

-      if (value === null || value === undefined || value.length === 0) {
+      if (value === null || value === undefined || value.length === 0 || value === '' || value === 0) {


@saurabhkushwaha438 Setting the CPU value to 0 does not clear the previously stored CPU count in the form. For example, after selecting a constrained offering, the form stores CPU = 2. When switching to an unconstrained custom offering, the CPU field displays 0 with the validation message "Please enter input". However, instance creation still proceeds successfully, and the VM is created with 2 CPUs, as the previously stored value is retained.

well this is not related to this issue

suryag1201 · 2026-11-02T15:02:06Z

+          memoryInMiB = Math.round(displayValue * 1024)
+        }
+      } else {
+        memoryInMiB = Math.round(displayValue)


@saurabhkushwaha438 Switching between MiB and GiB updates only the displayed memory value, while the deploy form continues to retain the previously entered MiB value.

On an unconstrained custom offering:

Enter 1100 MiB and then switch to GiB. The field displays 1.00 GiB, but when the instance is created, the deploy request still sends 1100 MiB (where 1.00 GiB = 1024 MiB).

Enter 100 MiB and then switch to GiB. The field displays 0 GiB, but instance creation still succeeds, and the deploy request sends 100 MiB, resulting in a VM being created with 100 MiB of memory.

thanks for pointing out this "Enter 100 MiB and then switch to GiB. The field displays 0 GiB, but instance creation still succeeds, and the deploy request sends 100 MiB, resulting in a VM being created with 100 MiB of memory."

thanks for pointing out this "Enter 100 MiB and then switch to GiB. The field displays 0 GiB, but instance creation still succeeds, and the deploy request sends 100 MiB, resulting in a VM being created with 100 MiB of memory."

hey i am not able reproduce this problem , could you attach screenshot of it

suryag1201 · 2026-11-02T15:15:33Z

+    maxMemoryInUnit () {
+      if (!this.maxMemory) return 0
+      if (this.memoryUnit === 'GiB') {
+        return Math.max(this.minMemoryInUnit, Math.floor(this.maxMemory / 256) * 0.25)


@saurabhkushwaha438 For custom offerings with a memory range like 2000-2300 MiB, the field is effectively restricted to 2.00 GiB when the unit is switched to GiB. The slider cannot be moved to any other value within the allowed range, preventing selection of valid memory sizes between 2000 MiB and 2300 MiB.

saurabhkushwaha438 · 2026-11-02T15:58:25Z

Description

Fixes #14082

1. Conversion from MiB to GiB (Display & Rounding)
Binary conversion is used (1 GiB = 1024 MiB).
When offerings with predefined constraints or initial values are loaded in MiB, or when switching from MiB to GiB:

displayValue

parseFloat
(

  (
  
    rawMemory
    1024
  
  )

.toFixed(2)
)
The display value is rounded to 2 decimal places to keep the UI clean, readable, and intuitive for users.

Slider step dynamically adjusts:

In GiB mode: step is set to 0.01 (or smaller for sub-GiB offerings) with precision 2.

In MiB mode: step is set to 1 with integer precision 0.
2. Conversion from GiB to MiB (Backend Value Emission)

CloudStack APIs and backend services expect memory allocations in integer MiB.

When the user selects or inputs memory in GiB:

memoryInMiB

Math.round
(
displayValue
×
1024
)

Exact Boundary Protection: If a compute offering has minimum/maximum memory constraints (minMemory / maxMemory), selecting the exact minimum or maximum bound in GiB directly maps to the exact integer minMemory or maxMemory in MiB to eliminate any potential off-by-one rounding discrepancies.

💬 Feedback Needed: Fractional GiB to Integer MiB Rounding

Observation: Converting decimal GiB values to MiB often produces fractional values (e.g., 1.51 GiB × 1024 = 1546.24 MiB).

Current Behavior: The UI rounds this to the nearest integer (1546 MiB), which is then emitted in the API payload and consumed by backend hypervisor managers.

Reviewer Input: Looking for maintainer feedback on whether standard nearest-integer rounding (Math.round) is acceptable, or if we should apply ceiling (Math.ceil) to guarantee the VM always receives at least the requested GiB amount.

bandicam.2026-10-16.10-21-12-210.mp4

@suryag1201 please go through this and then later i also make other changes according to feedback i was getting and here
is other Commits Description

ui: allow memory setting in flex compute offering in GiB with 0.25 GiB step (#14082)

Add compact unit selector dropdown (GiB/MiB) for flex compute offerings
Use fixed 0.25 GiB steps in GiB mode (binary-exact to 256 MiB intervals, zero rounding errors)
Maintain integer MiB as authoritative internal state to prevent lossy conversion on load
Default to GiB for 256 MiB multiples and MiB for arbitrary sizes (e.g. 1500 MiB)
Add hover tooltip to display exact converted values

boring-cyborg Bot added the component:UI label Oct 16, 2026

Damans227 reviewed Oct 16, 2026

View reviewed changes

Comment thread ui/src/views/compute/wizard/ComputeSelection.vue Resolved

nvazquez added this to the 24.0 milestone Oct 30, 2026

nvazquez mentioned this pull request Oct 30, 2026

UI: Please change memory setting in flex compute offering from MiB to GiB #14082

Open

saurabhkushwaha438 force-pushed the issue-14082-flex-memory-gib branch 2 times, most recently from 2c7e3a6 to c401af2 Compare October 30, 2026 06:42

Damans227 reviewed Oct 30, 2026

View reviewed changes

Comment thread ui/src/views/compute/wizard/ComputeSelection.vue Resolved

saurabhkushwaha438 force-pushed the issue-14082-flex-memory-gib branch from c401af2 to 6c3f959 Compare November 1, 2026 06:49

nvazquez added the type:improvement label Nov 1, 2026

nvazquez reviewed Nov 1, 2026

View reviewed changes

saurabhkushwaha438 force-pushed the issue-14082-flex-memory-gib branch from 6c3f959 to 171b008 Compare November 2, 2026 07:15

suryag1201 reviewed Nov 2, 2026

View reviewed changes

Conversation

saurabhkushwaha438 commented Oct 16, 2026

Description

1. Conversion from MiB to GiB (Display & Rounding)

2. Conversion from GiB to MiB (Backend Value Emission)

💬 Feedback Needed: Fractional GiB to Integer MiB Rounding

Uh oh!

Uh oh!

codecov Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nvazquez commented Oct 30, 2026

Uh oh!

blueorangutan commented Oct 30, 2026

Uh oh!

blueorangutan commented Oct 30, 2026

Uh oh!

Uh oh!

Damans227 commented Oct 30, 2026

Uh oh!

blueorangutan commented Oct 30, 2026

Uh oh!

blueorangutan commented Oct 30, 2026

Uh oh!

nvazquez commented Nov 1, 2026

Uh oh!

blueorangutan commented Nov 1, 2026

Uh oh!

blueorangutan commented Nov 1, 2026

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

saurabhkushwaha438 commented Nov 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saurabhkushwaha438 commented Nov 2, 2026

Description

1. Conversion from MiB to GiB (Display & Rounding)

displayValue

2. Conversion from GiB to MiB (Backend Value Emission)

memoryInMiB

💬 Feedback Needed: Fractional GiB to Integer MiB Rounding

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Oct 29, 2026 •

edited

Loading