Skip to content

Added vddk support in vmware to kvm migrations#12970

Draft
harikrishna-patnala wants to merge 6 commits intoapache:4.22from
shapeblue:Introduce-vddk-in-vmware-to-kvm-migrations-422
Draft

Added vddk support in vmware to kvm migrations#12970
harikrishna-patnala wants to merge 6 commits intoapache:4.22from
shapeblue:Introduce-vddk-in-vmware-to-kvm-migrations-422

Conversation

@harikrishna-patnala
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala commented Apr 7, 2026

Description

This PR introduces the VDDK implementation as part of VMware to KVM migration which reduces the migration time by half when compared to the existing implementation with exportOVF

Solution: Introduce VDDK configuration at both the host agent level and per-API-call level, wired through the migration execution pipeline on the KVM host.


Key Capabilities

Capability Detail
Host-level config Four new agent.properties keys configure VDDK defaults per KVM host
API-level overrides Callers can pass VDDK settings via importVm details, overriding host defaults
Secure password handling vCenter password written to a temp file, passed via -ip or --password-file based on virt-v2v version, and deleted immediately after use
Auto-thumbprint fetch If no thumbprint is configured, it is automatically retrieved from vCenter via openssl s_client

Configuration Keys

libguestfs.backend   # LIBGUESTFS backend (default: direct)
vddk.lib.dir         # Path to VDDK library directory
vddk.transports      # Transport preference, e.g. nbd:nbdssl
vddk.thumbprint      # vCenter SHA1 thumbprint (auto-fetched if unset)

Precedence

API details  >  agent.properties

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@harikrishna-patnala harikrishna-patnala force-pushed the Introduce-vddk-in-vmware-to-kvm-migrations-422 branch from b95cfb7 to 7dc5d50 Compare April 7, 2026 04:48
@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@harikrishna-patnala harikrishna-patnala added this to the 4.22.1 milestone Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 44.27245% with 180 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.62%. Comparing base (4708121) to head (7fb0b85).

Files with missing lines Patch % Lines
.../wrapper/LibvirtConvertInstanceCommandWrapper.java 46.82% 82 Missing and 10 partials ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 9.80% 46 Missing ⚠️
...va/com/cloud/agent/api/ConvertInstanceCommand.java 50.00% 15 Missing ⚠️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 69.76% 5 Missing and 8 partials ⚠️
.../java/com/cloud/agent/api/to/RemoteInstanceTO.java 53.84% 6 Missing ⚠️
...java/com/cloud/agent/manager/AgentManagerImpl.java 0.00% 5 Missing ⚠️
...e/cloudstack/api/command/admin/vm/ImportVmCmd.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12970      +/-   ##
============================================
+ Coverage     17.60%   17.62%   +0.01%     
- Complexity    15677    15698      +21     
============================================
  Files          5918     5918              
  Lines        531681   531982     +301     
  Branches      65005    65040      +35     
============================================
+ Hits          93623    93776     +153     
- Misses       427498   427631     +133     
- Partials      10560    10575      +15     
Flag Coverage Δ
uitests 3.70% <ø> (-0.01%) ⬇️
unittests 18.70% <44.27%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17380

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@blueorangutan package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants