Skip to content

Set snapCPG in online copy request to fix snapshot failures on cloned volumes #12955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poddm wants to merge 1 commit into
base: 4.22
Choose a base branch
from
+1 −0
Open

Set snapCPG in online copy request to fix snapshot failures on cloned volumes #12955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...src/main/java/org/apache/cloudstack/storage/datastore/adapter/primera/PrimeraAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,7 @@ public ProviderVolume copy(ProviderAdapterContext context, ProviderAdapterDataOb
// Online copy configuration: immediate clone with deduplication and compression
parms.setOnline(true);
parms.setDestCPG(cpg);
parms.setSnapCPG(snapCpg);
parms.setTpvv(false);
parms.setReduce(true);
logger.debug("PrimeraAdapter: Configuring online copy - destination CPG: '{}', deduplication enabled, thin provisioning disabled", cpg);
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug log message is now misleading/incomplete because the code configures snapCPG (and also reduce) but the log only prints destCPG and omits snapCPG. This makes troubleshooting harder and can contradict operator expectations (the PR description/test output includes snapCPG). Update the log format and arguments to include snapCpg (and optionally reduce) so the message reflects the actual online copy configuration.

Suggested change
logger.debug("PrimeraAdapter: Configuring online copy - destination CPG: '{}', deduplication enabled, thin provisioning disabled", cpg);
logger.debug("PrimeraAdapter: Configuring online copy - destination CPG: '{}', snapshot CPG: '{}', reduce enabled: {}, thin provisioning enabled: {}",
cpg, snapCpg, true, false);

Copilot uses AI. Check for mistakes.
Expand Down
Loading