kvm: fix wrong CheckVirtualMachineAnswer when vm does not exist by weizhouapache · Pull Request #12928 · apache/cloudstack

weizhouapache · 2026-03-31T10:21:05Z

Description

This PR should fix #12920

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2026-03-31T10:21:30Z

@blueorangutan package

blueorangutan · 2026-03-31T10:22:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-03-31T10:30:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.60%. Comparing base (59b6c32) to head (8fb2437).
⚠️ Report is 20 commits behind head on 4.22.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12928      +/-   ##
============================================
- Coverage     17.60%   17.60%   -0.01%     
- Complexity    15676    15678       +2     
============================================
  Files          5918     5918              
  Lines        531667   531667              
  Branches      65001    65001              
============================================
- Hits          93617    93611       -6     
- Misses       427491   427501      +10     
+ Partials      10559    10555       -4

Flag	Coverage Δ
uitests	`3.70% <ø> (ø)`
unittests	`18.67% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-03-31T11:29:47Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17307

DaanHoogland

makes sense

weizhouapache · 2026-03-31T11:55:33Z

@blueorangutan test

blueorangutan · 2026-03-31T11:56:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

.../com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckVirtualMachineCommandWrapperTest.java

…/resource/wrapper/LibvirtCheckVirtualMachineCommandWrapperTest.java Co-authored-by: dahn <daan.hoogland@gmail.com>

blueorangutan · 2026-04-01T03:45:18Z

[SF] Trillian test result (tid-15787)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53897 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12928-t15787-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti

code lgtm

kiranchavala

LGTM

Tested manually

Deployed a vm with ha offering on a kvm host1


[root@ref-trl-11549-k-Mol8-kiran-chavala-kvm1 ~]# virsh list
 Id   Name       State
--------------------------
 2    i-2-3-VM   running

virsh destroy removes the libvirt domain.
CloudStack detects the VM as missing.
After the graceful period expires, CloudStack updates the VM power report to PowerReportMissing.
The VM is restarted automatically on an eligible host and the state is shown as running

[root@ref-trl-11549-k-Mol8-kiran-chavala-kvm1 ~]# virsh list
 Id   Name       State
--------------------------
 3    i-2-3-VM   running

logs

2026-04-10 10:09:28,721 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-12:[]) (logid:) Detected missing VM. host: 1, vm id: 3(68a0af3d-5f59-4480-95dd-4af1456d6d2f), power state: PowerReportMissing, last state update: 2026-04-10T10:07:28+0000



2026-04-10 10:09:28,731 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-12:[]) (logid:) VM state report is updated. Host {"id":1,"name":"ref-trl-11549-k-Mol8-kiran-chavala-kvm1","type":"Routing","uuid":"f65d0b2f-e1f2-47f6-887d-31f26b257e1a"}, VM instance {"id":3,"instanceName":"i-2-3-VM","state":"Running","type":"User","uuid":"68a0af3d-5f59-4480-95dd-4af1456d6d2f"}, power state: PowerReportMissing

2026-04-10 10:09:28,741 INFO  [c.c.v.ClusteredVirtualMachineManagerImpl] (AgentManager-Handler-12:[ctx-5542e17c]) (logid:) VM VM instance {"id":3,"instanceName":"i-2-3-VM","state":"Running","type":"User","uuid":"68a0af3d-5f59-4480-95dd-4af1456d6d2f"} is at Running and we received a PowerReportMissing report while there is no pending jobs on it

2026-04-10 10:09:28,742 INFO  [c.c.v.ClusteredVirtualMachineManagerImpl] (AgentManager-Handler-12:[ctx-5542e17c]) (logid:) Detected out-of-band stop of a HA enabled VM VM instance {"id":3,"instanceName":"i-2-3-VM","state":"Running","type":"User","uuid":"68a0af3d-5f59-4480-95dd-4af1456d6d2f"}, will schedule restart.

2026-04-10 10:09:28,744 DEBUG [c.c.h.HighAvailabilityManagerExtImpl] (AgentManager-Handler-12:[ctx-5542e17c]) (logid:) HA schedule restart

2026-04-10 10:09:28,750 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (AgentManager-Handler-12:[ctx-5542e17c]) (logid:) Schedule vm for HA:  VM instance {"id":3,"instanceName":"i-2-3-VM","state":"Running","type":"User","uuid":"68a0af3d-5f59-4480-95dd-4af1456d6d2f"}

2026-04-10 10:09:28,750 DEBUG [c.c.h.HighAvailabilityManagerExtImpl] (AgentManager-Handler-12:[ctx-5542e17c]) (logid:) Wakeup workers HA

2026-04-10 10:09:28,750 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (AgentManager-Handler-12:[ctx-5542e17c]) (logid:) Done with process of VM state report. host: Host {"id":1,"name":"ref-trl-11549-k-Mol8-kiran-chavala-kvm1","type":"Routing","uuid":"f65d0b2f-e1f2-47f6-887d-31f26b257e1a"}

2026-04-10 10:09:28,759 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) Processing work HAWork[1-HA-3-Running-Investigating]

2026-04-10 10:09:28,768 DEBUG [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) RESTART with HAWORK

2026-04-10 10:09:28,772 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) HA on VM instance {"id":3,"instanceName":"i-2-3-VM","state":"Running","type":"User","uuid":"68a0af3d-5f59-4480-95dd-4af1456d6d2f"}
2026-04-10 10:09:28,775 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) Wait time setting on com.cloud.agent.api.CheckVirtualMachineCommand is 20 seconds


2026-04-10 10:09:28,776 DEBUG [c.c.a.m.ClusteredAgentAttache] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) Seq 4-8020347986393432246: Routed from 32985566938254

2026-04-10 10:09:28,776 DEBUG [c.c.a.t.Request] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) Seq 1-8020347986393432246: Sending  { Cmd , MgmtId: 32985566938254, via: 1(
ref-trl-11549-k-Mol8-kiran-chavala-kvm1), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.CheckVirtualMachineCommand":{"vmName":"i-2-3-VM","wait":"20","bypassHostMaintenance":"false"}}] }

2026-04-10 10:09:28,785 DEBUG [c.c.a.t.Request] (AgentManager-Handler-13:[]) (logid:) Seq 1-8020347986393432246: Processing:  { Ans: , MgmtId: 32985566938254, via: 1, Ver: v1, Flags: 10, [{"com.cloud.agent.api.CheckVirtualMachineAnswer":{"state":"PowerOff","result":"true","wait":"0","bypassHostMaintenance":"false"}}] }

2026-04-10 10:09:28,785 DEBUG [c.c.a.t.Request] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) Seq 1-8020347986393432246: Received:  { Ans: , MgmtId: 32985566938254, via: 1(ref-trl-11549-k-Mol8-kiran-chavala-kvm1), Ver: v1, Flags: 10, { CheckVirtualMachineAnswer } }

2026-04-10 10:09:36,141 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) HA is now restarting VM instance {"id":3,"instanceName":"i-2-3-VM","state":"Running","type":"User","uuid":"68a0af3d-5f59-4480-95dd-4af1456d6d2f"} on Host {"id":1,"name":"ref-trl-11549-k-Mol8-kiran-chavala-kvm1","type":"Routing","uuid":"f65d0b2f-e1f2-47f6-887d-31f26b257e1a"}

2026-04-10 10:09:36,157 INFO  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-2:[ctx-e2886928, work-1]) (logid:fcb78e90) Completed work HAWork[1-HA-3-Running-Scheduled]. Took 1/5 attempts.

kvm: fix wrong CheckVirtualMachineAnswer when vm does not exist

ad7e45e

boring-cyborg bot added the component:kvm label Mar 31, 2026

weizhouapache linked an issue Mar 31, 2026 that may be closed by this pull request

KVM HA: VM remains Running after virsh destroy; PowerReportMissing schedules HA but KVMInvestigator reports alive=true and restart is cancelled #12920

Closed

DaanHoogland approved these changes Mar 31, 2026

View reviewed changes

kvm: add LibvirtCheckVirtualMachineCommandWrapperTest

f91a776

DaanHoogland reviewed Mar 31, 2026

View reviewed changes

.../com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckVirtualMachineCommandWrapperTest.java Outdated Show resolved Hide resolved

Update plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm…

8fb2437

…/resource/wrapper/LibvirtCheckVirtualMachineCommandWrapperTest.java Co-authored-by: dahn <daan.hoogland@gmail.com>

sureshanaparti approved these changes Apr 1, 2026

View reviewed changes

sureshanaparti added this to the 4.22.1 milestone Apr 1, 2026

sureshanaparti added this to Apache CloudStack 4.22.1 Apr 1, 2026

github-project-automation bot moved this to Todo in Apache CloudStack 4.22.1 Apr 1, 2026

sureshanaparti moved this from Todo to In Progress in Apache CloudStack 4.22.1 Apr 1, 2026

weizhouapache marked this pull request as ready for review April 1, 2026 07:30

sureshanaparti added status:needs-testing ready-for-testing labels Apr 1, 2026

kiranchavala approved these changes Apr 10, 2026

View reviewed changes

kiranchavala added status:ready-for-merge and removed status:needs-testing ready-for-testing labels Apr 10, 2026

sureshanaparti merged commit 273699c into apache:4.22 Apr 10, 2026
25 of 26 checks passed

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.1 Apr 10, 2026

sureshanaparti mentioned this pull request Apr 10, 2026

KVM HA: VM remains Running after virsh destroy; PowerReportMissing schedules HA but KVMInvestigator reports alive=true and restart is cancelled #12920

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kvm: fix wrong CheckVirtualMachineAnswer when vm does not exist#12928

kvm: fix wrong CheckVirtualMachineAnswer when vm does not exist#12928
sureshanaparti merged 3 commits intoapache:4.22from
weizhouapache:4.22-fix-virsh-destroy-vm-ha

weizhouapache commented Mar 31, 2026

Uh oh!

weizhouapache commented Mar 31, 2026

Uh oh!

blueorangutan commented Mar 31, 2026

Uh oh!

codecov bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

blueorangutan commented Mar 31, 2026

Uh oh!

DaanHoogland left a comment

Uh oh!

weizhouapache commented Mar 31, 2026

Uh oh!

blueorangutan commented Mar 31, 2026

Uh oh!

Uh oh!

blueorangutan commented Apr 1, 2026

Uh oh!

sureshanaparti left a comment

Uh oh!

kiranchavala left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

weizhouapache commented Mar 31, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Mar 31, 2026

Uh oh!

blueorangutan commented Mar 31, 2026

Uh oh!

codecov bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Mar 31, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Mar 31, 2026

Uh oh!

blueorangutan commented Mar 31, 2026

Uh oh!

Uh oh!

blueorangutan commented Apr 1, 2026

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Mar 31, 2026 •

edited

Loading

kiranchavala left a comment •

edited

Loading