Change exception treatment on incremental snapshot wait#12665
Change exception treatment on incremental snapshot wait#12665JoaoJandre wants to merge 2 commits intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12665 +/- ##
=========================================
Coverage 17.92% 17.92%
- Complexity 16154 16155 +1
=========================================
Files 5939 5939
Lines 533181 533181
Branches 65237 65237
=========================================
Hits 95585 95585
Misses 426856 426856
Partials 10740 10740
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug in the KVM incremental volume snapshot creation process where thread interruptions during the wait for Libvirt's backup-begin command would cause snapshot failures. The change modifies the exception handling to log interruptions and continue waiting instead of throwing an exception.
Changes:
- Modified exception handling in
waitForBackup()to log InterruptedException at trace level and continue waiting instead of throwing CloudRuntimeException
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
Outdated
Show resolved
Hide resolved
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
Outdated
Show resolved
Hide resolved
…/storage/KVMStorageProcessor.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
During the KVM incremental volume snapshot creation process, ACS waits for Libvirt's
backup-begincommand to finish; during this period, there is a possibility that the thread that is waiting is interrupted, if that happens, an exception is thrown and the snapshot fails.This PR changes the exception handling so that the thread only informs that it was interrupted in the logs and goes back to waiting for the Libvirt process to finish.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?