Skip to content

Comments

constructing the expiry Prometheus Item according to new format#12653

Merged
DaanHoogland merged 1 commit intomainfrom
mergeFixInPrometheusExporter
Feb 17, 2026
Merged

constructing the expiry Prometheus Item according to new format#12653
DaanHoogland merged 1 commit intomainfrom
mergeFixInPrometheusExporter

Conversation

@DaanHoogland
Copy link
Contributor

Description

This PR fixes a merge forwards problem...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Prometheus exporter’s host certificate expiry metric to follow the newer Item metadata format (name/help/type), addressing a merge-forward incompatibility with the current Item base class constructor.

Changes:

  • Update ItemHostCertExpiry to call the 3-argument Item constructor with metric name, help text, and type.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.92%. Comparing base (a7dc5ef) to head (f1ffceb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main   #12653       +/-   ##
============================================
+ Coverage     3.67%   17.92%   +14.25%     
- Complexity       0    16154    +16154     
============================================
  Files          454     5939     +5485     
  Lines        38539   533151   +494612     
  Branches      7125    65228    +58103     
============================================
+ Hits          1415    95589    +94174     
- Misses       36937   426823   +389886     
- Partials       187    10739    +10552     
Flag Coverage Δ
uitests 3.67% <ø> (ø)
unittests 19.03% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland DaanHoogland merged commit 22cda0c into main Feb 17, 2026
43 of 55 checks passed
@DaanHoogland DaanHoogland deleted the mergeFixInPrometheusExporter branch February 17, 2026 13:42
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants