constructing the expiry Prometheus Item according to new format#12653
constructing the expiry Prometheus Item according to new format#12653DaanHoogland merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Prometheus exporter’s host certificate expiry metric to follow the newer Item metadata format (name/help/type), addressing a merge-forward incompatibility with the current Item base class constructor.
Changes:
- Update
ItemHostCertExpiryto call the 3-argumentItemconstructor with metric name, help text, and type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12653 +/- ##
============================================
+ Coverage 3.67% 17.92% +14.25%
- Complexity 0 16154 +16154
============================================
Files 454 5939 +5485
Lines 38539 533151 +494612
Branches 7125 65228 +58103
============================================
+ Hits 1415 95589 +94174
- Misses 36937 426823 +389886
- Partials 187 10739 +10552
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|




Description
This PR fixes a merge forwards problem...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?