Fix VPC network offerings listing in isolated network creation form#12645
Open
erikbocks wants to merge 1 commit intoapache:mainfrom
Open
Fix VPC network offerings listing in isolated network creation form#12645erikbocks wants to merge 1 commit intoapache:mainfrom
erikbocks wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12645 +/- ##
============================================
+ Coverage 16.26% 17.90% +1.63%
- Complexity 13428 16093 +2665
============================================
Files 5660 5938 +278
Lines 499963 532864 +32901
Branches 60708 65192 +4484
============================================
+ Hits 81330 95391 +14061
- Misses 409559 426794 +17235
- Partials 9074 10679 +1605
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when creating a new isolated network, it is possible to assign it as a VPC tier. The VPC assignment field is shown only when a VPC network offering is selected. However, it was noticed that VPC network offerings are listed only if the current user has at least one VPC. Otherwise, VPC network offering were not listed and it was necessary to access another account that has a VPC or create a dummy VPC.
Changes were made,to list offerings based on the form selected account instead of the current user. Besides that, an warning was added below the network offerings field informing that VPC network offerings will be shown only if the selected account has at least one VPC.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Warning message:
No VPC user offerings
No warning shown for account that has a VPC:
VPC network offerings listed for a account that has a VPC
How Has This Been Tested?
Logged in with the
adminaccount, I created a VPC to theradmaccount. Then, I accessed the isolated network creation form and validated that the VPC offerings were not shown (because the current account did not had a VPC). Then, I applied the PR changes to my local environment.With the changes applied, the isolated network form was accessed again, and it was possible to see the warning message. When the
radmwas selected in the form, the warning message was hidden and the VPC offerings were listed successfully.The same tests were reproduced for projects.